Repository navigation
Defaults for new drivers (timezone, distance unit, language) from system settings #51
Closed
MarcoSpittka
started this conversation in
Ideas
Replies: 2 comments
|
Thanks @MarcoSpittka, this is a good catch. We are building it for v0.1.51:
Existing drivers keep their values. Once v0.1.51 is out, you can set the new settings and put your column defaults back to the shipped ones, so updates no longer touch them. |
0 replies
|
This shipped in v0.1.51. New drivers now take the company timezone and the new driver distance unit and language defaults from Settings > Company. See Company Info and driver timezone. Thanks again @MarcoSpittka. Closing as resolved; open a new discussion if anything needs a follow-up. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi, a small suggestion for operators outside the US:
New drivers always start with
America/New_York,milesanden. These are the column defaults inpackages/database/src/schema/drivers.ts, and neitherPOST /driversnor the portal registration sets them. The configuredsystem.timezoneisn't used there, and operators can't change a driver's distance unit afterwards (PATCH /drivers/{id}acceptstimezoneandlanguage, but notdistanceUnit). The CSMS "Create driver" form also preselectsen.It would help if new drivers took their defaults from the system settings:
system.timezonesystem.distanceUnitandsystem.driverLanguage(or the company language, if there is one)distanceUniteditable viaPATCH /drivers/{id}and on the driver detail pageFor now we changed the column defaults directly in our database, but a settings-based default would survive updates. Thanks for considering it!
All reactions