Repository navigation
[Bug] Oauth 1 signature calculations does not include body #1137
Description
- Insomnia Version: 6.0.2
- Operating System: Win 7 SP2
Details
According to the specification, body parameters are included in signature calculations. This is done by putting them in the requestData.data object for oauth-1.0a. However, this isn't done in the linking code. I guess this is because there's no nice way to deal with body content as parameters.
Activity
welcome commentedon Aug 24, 2018
👋 Thanks for opening your first issue! If you're reporting a 🐞 bug, please make sure
you include steps to reproduce it. If you're requesting a feature 🎁, please provide real
use cases that would benefit. 👪
To help make this a smooth process, please be sure you have first read the
contributing guidelines.
gschier commentedon Aug 27, 2018
I haven't really ever used OAuth 1.0, so don't know much about it. But, it seems like the body should only be included in the signature base string if it's a
application/x-www-form-urlencodedrequest.It seems like it should be an easy thing to add. Like you said, we should just need to decode the body and put each key/value pair in the
dataparameter.wdawson commentedon Jul 1, 2021
Sorry folks! This was incorrectly tagged as a feature request along with other bugs. I'm going back through and cleaning up, sorry for the inconvenience.