Repository navigation
fix: switch to lua5.4 and link against libdisplay-info3 - #13
Conversation
|
TAG Bot TAG: 0.40.0-3+deb13u1deepin3 |
|
Hi @add-uos. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
feb958e to
718983d
Compare
add-uos
changed the title
Log: - Build against libdisplay-info-dev (0.3.0) normally, so mpv links libdisplay-info.so.3 and depends on libdisplay-info3 instead of the old libdisplay-info1 soname. - Switch the Lua scripting engine from lua5.2 to lua5.4 via a quilt patch (0006-add-lua5.4-support.patch): probe lua54/lua5.4/lua-5.4 in meson.build/meson.options, configure the build with -Dlua=lua5.4, and relax the runtime version check in player/lua.c to accept 5.3 and 5.4. - The patch also keeps Lua 5.1/5.2's permissive luaL_checkinteger behavior (truncate non-integral floats instead of raising "number has no integer representation") so scripts like osc.lua keep working on 5.4. Influence: mpv/libmpv2 runtime dependencies change from libdisplay-info1 to libdisplay-info3 and from liblua5.2-0 to liblua5.4-0.
718983d to
3c1e1b4
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
|
/hold |
目的
di_*符号及全部结构体在 0.3.0 中 API/ABI 均兼容，无需改动源码。debian/patches/0006-add-lua5.4-support.patch提交）：meson.build/meson.options依赖探测列表增加lua54/lua5.4/lua-5.4，debian/rules传-Dlua=lua5.4；player/lua.c运行时版本检查放宽为 5.1–5.4；luaL_checkinteger行为（非整浮点截断而非报错），否则 osc.lua 的set_virt_mouse_area会因 "number has no integer representation" 报错失效。验证
dpkg-buildpackage -us -uc -b构建通过（quilt patch 正常应用/撤销）；NEEDED为libdisplay-info.so.3和liblua5.4.so.0，deb 依赖为libdisplay-info3+liblua5.4-0；变更依赖
mpv / libmpv2 运行时依赖：
libdisplay-info1→libdisplay-info3，liblua5.2-0→liblua5.4-0。