Repository navigation
Conversation
molinaro-m
approved these changes
May 20, 2024
molinaro-m
left a comment
molinaro-m
left a comment
Member
There was a problem hiding this comment.
Style pointers now look OK.
I think there's still place for a better responsiveness, but that will come later on.
JeremyMcCormick
requested changes
May 21, 2024
Collaborator
There was a problem hiding this comment.
This is a huge improvement - thanks for this update!
My requested changes would be:
- Improve the text in the carousel. The title is too big and the author too small.
- Make a row including the carousel and newsletter together (implicit in this suggestion is decreasing the size of the carousel which seems too big now)
- Have the prose content on the landing page be on its own row
- Change footer labels like "About IVOA" to grey text
- Change the now light blue footer links to white
Following discussion, these changes could be incorporated on separate PRs if you wish.
(These are mostly just my preferences.)
JeremyMcCormick
approved these changes
May 21, 2024
JeremyMcCormick
left a comment
JeremyMcCormick
left a comment
Collaborator
There was a problem hiding this comment.
I am going to leave it up to you what changes to include in this PR based on my feedback (see checklist).
Additional improvements we decide to make in this area can be implemented on separate issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of a draft now. There is clearly matter of improvement (especially to make it render better on small screens like smartphone). Few things can still be fixed before merging.
Fixes #6