Repository navigation
Prepare links for migration - #23
Conversation
|
I may still change one breaking thing:
Otherwise, URLs would be Just tell me if it is a bad idea. |
+ Move the newsletter example in the newsletter directory This way URLs won't be, for instance, `https://ivoa.net/pages/about/` but `https://ivoa.net/about/`.
…e home page (~2MB into ~600kB)
|
Ok.According to me, this PR is now ready for review and to be merged. |
| <li><a href="{{ .Site.Home.Permalink}}/astronomers/getting_started/">Getting Started</a></li> | ||
| <li><a href="{{ .Site.Home.Permalink}}/astronomers/using_the_vo/">Using the VO</a></li> | ||
| <li><a href="{{ .Site.Home.Permalink}}/astronomers/vo_glossary/">VO Glossary</a></li> | ||
| <li><a href="{{ .Site.Home.Permalink}}/astronomers/applications/">VO Applications</a></li> | ||
| <li><a href="{{ .Site.Home.Permalink}}/newsletter/">IVOA newsletter</a></li> | ||
| <li><a href="{{ .Site.Home.Permalink}}/astronomers/vo_for_public/">VO for Students & Public</a></li> |
There was a problem hiding this comment.
I think these all have an extra "/" between the {{ .Site.Home.Permlink}} and the folder. It works in the browser anyway, but maybe we can remove it.
There was a problem hiding this comment.
Yes, I have noticed that too. As it does not seem to be an issue, I have not put an high priority to solve this yet. But I can have a quick look now, if you want to.
There was a problem hiding this comment.
no, definitely no need to prioritise this, let's just keep it in mind
molinaro-m
left a comment
molinaro-m
left a comment
There was a problem hiding this comment.
Besides the small comment, I thin this is fine.
I checked the version's outcome on the webstage and looks fine.
JeremyMcCormick
left a comment
JeremyMcCormick
left a comment
There was a problem hiding this comment.
Looks good to me. The link for the one ported page works fine and the others are 404 now but I assume that is intended here so we can work on adding the new pages that are pointed to now.
We need to update a few things in the contributing guide based on these changes, but I can do that on another branch.
This PR updates links of the sitemap (list of links available at the bottom of all website pages). All links (except Wiki and Documents links) are now made relative to this prototype website.
Don't hesitate to tell me if I forgot some or if I fixed the wrong one or in the wrong way.
FIxes #22