From 306c85c146796d437ad820148762c452d8908b51 Mon Sep 17 00:00:00 2001 From: Arya Massarat <23412689+aryarm@users.noreply.github.com> Date: Thu, 12 Mar 2026 13:10:35 -0700 Subject: [PATCH 1/3] Fetch "latest" version from GitHub API excluding pre-releases Added logic to fetch the "latest" version from the GitHub API so that pre-releases aren't included --- src/miniforge/install.sh | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/miniforge/install.sh b/src/miniforge/install.sh index 3b32cc8..7ac8a43 100755 --- a/src/miniforge/install.sh +++ b/src/miniforge/install.sh @@ -87,12 +87,19 @@ find_version_from_git_tags() { check_packages ca-certificates version_list="$(git ls-remote --tags "${repository}" | grep -oP "${regex}" | tr -d ' ' | tr "${separator}" "." | sort -rV)" if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "current" ] || [ "${requested_version}" = "lts" ]; then - declare -g "${variable_name}"="$(echo "${version_list}" | head -n 1)" - else - set +e - declare -g "${variable_name}"="$(echo "${version_list}" | grep -E -m 1 "^${requested_version//./\\.}([\\.\\s]|$)")" - set -e + if [ "${repository}" = "https://github.com/conda-forge/miniforge" ]; then + check_packages curl + requested_version="$(curl -fsSL "https://api.github.com/repos/conda-forge/miniforge/releases/latest" | sed -nE 's/^[[:space:]]*"tag_name":[[:space:]]*"([^"]+)".*/\1/p')" + if [ -z "${requested_version}" ]; then + requested_version="$(echo "${version_list}" | head -n 1)" + fi + else + requested_version="$(echo "${version_list}" | head -n 1)" + fi fi + set +e + declare -g "${variable_name}"="$(echo "${version_list}" | grep -E -m 1 "^${requested_version//./\\.}([\\.\\s]|$)")" + set -e fi if [ -z "${!variable_name}" ] || ! echo "${version_list}" | grep "^${!variable_name//./\\.}$" >/dev/null 2>&1; then echo -e "Invalid ${variable_name} value: ${requested_version}\nValid values:\n${version_list}" >&2 From 0d02cec902d4fb548bd187f1351fe22b602f0160 Mon Sep 17 00:00:00 2001 From: Arya Massarat <23412689+aryarm@users.noreply.github.com> Date: Fri, 13 Mar 2026 11:35:38 -0700 Subject: [PATCH 2/3] try to avoid rate limits as much as possible (#1) * refactor for explicit fallback and fix error in find * Enhance version retrieval in install.sh Added error handling for curl command and improved version retrieval logic. * Enhance install.sh to use GITHUB_TOKEN for API calls Add support for GitHub API token in install script --- src/miniforge/install.sh | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/miniforge/install.sh b/src/miniforge/install.sh index 7ac8a43..b10c23b 100755 --- a/src/miniforge/install.sh +++ b/src/miniforge/install.sh @@ -51,7 +51,7 @@ elif [ "${USERNAME}" = "none" ] || ! id -u "${USERNAME}" >/dev/null 2>&1; then fi apt_get_update() { - if [ "$(find /var/lib/apt/lists/* | wc -l)" = "0" ]; then + if [ ! -d /var/lib/apt/lists ] || [ -z "$(ls -A /var/lib/apt/lists 2>/dev/null)" ]; then echo "Running apt-get update..." apt-get update -y fi @@ -87,13 +87,20 @@ find_version_from_git_tags() { check_packages ca-certificates version_list="$(git ls-remote --tags "${repository}" | grep -oP "${regex}" | tr -d ' ' | tr "${separator}" "." | sort -rV)" if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "current" ] || [ "${requested_version}" = "lts" ]; then + requested_version="" if [ "${repository}" = "https://github.com/conda-forge/miniforge" ]; then check_packages curl - requested_version="$(curl -fsSL "https://api.github.com/repos/conda-forge/miniforge/releases/latest" | sed -nE 's/^[[:space:]]*"tag_name":[[:space:]]*"([^"]+)".*/\1/p')" - if [ -z "${requested_version}" ]; then - requested_version="$(echo "${version_list}" | head -n 1)" - fi - else + github_api_headers=() + if [ -n "${GITHUB_TOKEN:-}" ]; then + # use GITHUB_TOKEN to raise rate limits + github_api_headers=(-H "Authorization: Bearer ${GITHUB_TOKEN}" -H "X-GitHub-Api-Version: 2022-11-28") + fi + set +e + requested_version="$(curl -fsSL "${github_api_headers[@]}" "https://api.github.com/repos/conda-forge/miniforge/releases/latest" | sed -nE 's/^[[:space:]]*"tag_name":[[:space:]]*"([^"]+)".*/\1/p')" + set -e + fi + # fallback to most recent git tag if rate limit exceeded; this may unfortunately include pre-releases + if [ -z "${requested_version}" ]; then requested_version="$(echo "${version_list}" | head -n 1)" fi fi From 2edad3f3ef0dcf2500f497bea9fa281b36fc5099 Mon Sep 17 00:00:00 2001 From: Arya Massarat <23412689+aryarm@users.noreply.github.com> Date: Mon, 16 Mar 2026 18:11:43 -0700 Subject: [PATCH 3/3] update patch version of miniforge to 2.0.2 --- src/miniforge/devcontainer-feature.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/miniforge/devcontainer-feature.json b/src/miniforge/devcontainer-feature.json index df00022..24d1511 100644 --- a/src/miniforge/devcontainer-feature.json +++ b/src/miniforge/devcontainer-feature.json @@ -1,7 +1,7 @@ { "name": "Conda, Mamba (Miniforge)", "id": "miniforge", - "version": "2.0.1", + "version": "2.0.2", "description": "Installs Conda and Mamba package manager and Python3. conda-forge set as the default (and only) channel.", "documentationURL": "https://github.com/rocker-org/devcontainer-features/tree/main/src/miniforge", "options": {