Skip to content

Commit 6aea2a1

Browse files
authored
Add layout.writing-mode.sideways.enabled pref (#486)
This will allow servo to enable `writing-mode` excluding the sideways values (`sideways-lr` and `sideways-rl`). Signed-off-by: Oriol Brufau <obrufau@igalia.com>
1 parent c81cd9c commit 6aea2a1

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

‎style/logical_geometry.rs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ pub enum InlineBaseDirection {
2323
RightToLeft,
2424
}
2525

26+
fn sideways_enabled(_: &crate::parser::ParserContext) -> bool {
27+
crate::pref!("layout.writing-mode.sideways.enabled", gecko = true)
28+
}
29+
2630
/// The writing-mode property (different from the WritingMode enum).
2731
/// https://drafts.csswg.org/css-writing-modes/#block-flow
2832
/// Aliases come from https://drafts.csswg.org/css-writing-modes-4/#svg-writing-mode
@@ -50,7 +54,9 @@ pub enum WritingModeProperty {
5054
#[parse(aliases = "tb,tb-rl")]
5155
VerticalRl,
5256
VerticalLr,
57+
#[parse(condition = "sideways_enabled")]
5358
SidewaysRl,
59+
#[parse(condition = "sideways_enabled")]
5460
SidewaysLr,
5561
}
5662

‎stylo_static_prefs/preferences.toml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,4 @@
5656
"layout.unimplemented" = false
5757
"layout.variable_fonts.enabled" = false
5858
"layout.writing-mode.enabled" = false
59+
"layout.writing-mode.sideways.enabled" = false

0 commit comments

Comments
 (0)