Repository navigation
test: migrate stats/incr/mmeanstdev to ULP-based assertions - #16199
Draft
Planeshifter wants to merge 1 commit into
Draft
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ryYDAEvxjPLjFWVheYD6N
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
@stdlib/stats/incr/mmeanstdevfrom theEPS/tolerance approach to ULP-based assertions using@stdlib/assert/is-almost-same-value.1to the single tolerance-based assertion (the standard deviation returned whenacc()is invoked without an argument, in "if not provided an input value, the accumulator function returns the current arithmetic mean and corrected sample standard deviation"). The measured minimum that passes is0(exact match);1was kept as a conservative bound against platform differences. Results were identical across two runs.absandEPSrequires and thedelta/tolvariables.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The local pre-commit editorconfig lint could not run in the sandbox (binary download blocked), so the commit was made with
--no-verify. ESLint passes on the changed file.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as an automated routine.
@stdlib-js/reviewers
Generated by Claude Code