Repository navigation
Update ten packages; hold xunit at 3 - #21
Merged
Merged
Conversation
…or 2.0 Avalonia, Avalonia.Desktop, Avalonia.Skia, Avalonia.Themes.Fluent, Avalonia.Fonts.Inter and Avalonia.Headless.XUnit 12.1.3 to 12.1.4; DocumentFormat.OpenXml 3.3.0 to 3.5.1; Microsoft.Data.Sqlite 10.0.12 to 10.0.13; QRCoder 1.6.0 to 1.8.1; xunit.runner.visualstudio 3.1.4 to 3.1.5. #14 edited the project files from before central package management, so these go in Directory.Packages.props instead. All MIT or Apache-2.0. Avalonia 12.1.4 needs SkiaSharp 3.119.4 and HarfBuzzSharp 8.3.1.3, which are already the pinned versions. With FEMA's answer key: 1,218 passed, 0 skipped, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Avalonia.Headless.XUnit (12.1.4 too) is built on xunit v3 3.x, and xunit 4 runs only on Microsoft Testing Platform: Dependabot's xunit.v3 4.0.2 PR failed every build with "Testing with VSTest target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK". The xunit packages move to a new major together, with an Avalonia release that supports it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Dependabot's open PRs (#14 to #17) edit version numbers in the project files, but since 2.5 (#19) every package
version lives in
Directory.Packages.props(central package management), so none of them applies any more. ThisPR takes the updates that work, in the central file, and holds back the ones that can't work yet.
Updated (from #14, all minor or patch, all MIT or Apache-2.0):
Avalonia 12.1.4 needs SkiaSharp 3.119.4 and HarfBuzzSharp 8.3.1.3, which are already the pinned versions.
Held back: xunit 4 (#15 xunit.runner.visualstudio 4.0.1, #16 xunit.v3 4.0.2, #17 xunit.v3.assert 4.0.2).
Avalonia.Headless.XUnit(12.1.4 included) is built on xunit v33.2.2.
longer supported by Microsoft.Testing.Platform on .NET 10 SDK".
.github/dependabot.ymlnow ignores new xunit majors, with the reason. The xunit packages move together, with anAvalonia release that supports xunit 4.
How it was tested
dotnet test Sde.slnwith FEMA's answer key set up: 1,218 passed, 0 skipped, 0 failed.MapToolsTests.ScreenshotsOfTheMapPage_LightAndDark_WithALayerAndFloodZones,which was already known to be flaky under load before these updates. It then passed three times on its own, and two
more full app-test runs passed (269 of 269).
none are included.
Checklist
dotnet build Sde.slnanddotnet test Sde.slnpass.src/Sde.Calculation,src/Sde.Data/Seedor the export formats, I ran the tests with FEMA'sanswer key (
tools/answer-key/setup.sh) and they pass. (It doesn't touch them; the answer-key tests pass too.).mdbimport and SDE_n folders are unchanged, or this PR explains why FEMA's SDE still reads them.decomp/,reference/OriginalCalc/orextracted/.docs/screenshots/changed only if the UI was meant to change. (Unchanged.)Replaces #14, #15, #16 and #17.
🤖 Generated with Claude Code