Repository navigation
[ALICE3] TRK/FT3 digitizer: introduced discretization of the timestamp into digits with the ALMIRA ToA timestamp format #16137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atriolo
wants to merge
9
commits into
AliceO2Group:dev
Choose a base branch
from
atriolo:timestamp
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−20
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3e6db16
TRK/FT3 digitizer: changed digit ToA format from float to the format …
atriolo eef4e26
TRKDigitizerSpec workflow: now the number of ROFs per TF is computed …
atriolo d2e5d97
TRKFT3 digitizer: changed long LOG print from info to debug
atriolo 10140db
small namming fix
atriolo ab04baa
LOG(info) -> LOG(debug) for annoying log
atriolo 1dfcbac
retrigger CI
atriolo fb14dc3
Please consider the following formatting changes
alibuild 052419b
Merge pull request #11 from alibuild/alibot-cleanup-16137
atriolo b27a87e
Fix: ROF length must be a multiple of the clock period (std::round + …
atriolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not std::round, w/o custom margin ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for yout comment!
You are right, I overlooked this. This was a leftover from when I did not yet have detailed information on the relation between the ROF and the clock cycles, so I allowed a ROF length not multiple of the clock period, with a shorter last cycle.
In that case the number of cycles has to be rounded up (e.g. 17 BC with a 4 BC clock needs 5 cycles, while std::round would give 4), hence the std::ceil, and the custom margin was there to protect the ceil from float rounding (18 × 24.95 / 24.95 → 18.000001 → 19).
Now that I know from the designers that the ROF length is always a multiple of the clock period, there is no partial cycle and that calculation no longer makes sense.
So I am going to replace it with std::round and add a fatal check in the digitizer that the ROF length should be a multiple of the clock period.
Please let me know if you have other thoughts about this, thanks again!