Repository navigation
o2-sim: Tell the exited volume by its path in VecGeom navigation - #16144
Merged
sawenzel merged 2 commits intoNov 17, 2026
Merged
Conversation
This fixes tracks stopping in the mother when they leave a volume into another copy of its container. - After an exit through coinciding faces the locate must not descend back into the volume just left. - That volume was recognised by its placement alone, which also sits in every other copy of its mother. - A track going from a tile in one EMCAL tower to the same tile in the neighbouring tower was therefore left in the air around the towers, with a zero-length step. - The volume is now recognised by its whole path. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This adds a unit test that compares the relocating VecGeom navigator with TGeo. - The geometry is two towers of tiles side by side whose faces coincide, as in a sampling calorimeter. - Rays have to visit the same volumes with the same step lengths as with TGeo. - No zero-length step may occur in a mother the ray only touches. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixing a bug where the VecGeom navigator (
G4.navmode=kVecGeom) left a track in the mother volume with a zero-length step when it went from a volume into the same volume of a neighbouring copy of the mother.The navigator recognised the volume it had just left by its placement alone. A second copy of the mother holds the same placement, so a track going from a tile in one EMCAL tower into the same tile of the next tower was stopped in the air between them, where photons below the 1 MeV cut of the air ended. The whole path is now compared.
With this change and #16142, 3000 photons of 1 GeV/c into the EMCAL give the same number of steps (0.9996) and the same visible energy (−0.15 % ± 0.25 %) as TGeo navigation. A unit test navigates rays through two towers of touching tiles and compares the volumes visited with TGeo.
Assisted by Claude Code.