Skip to content

Restrict the active detectors to the chosen detector list - #2549

Open
sawenzel wants to merge 1 commit into
AliceO2Group:masterfrom
sawenzel:detectorlist-active-modules
Open

sawenzel wants to merge 1 commit into
AliceO2Group:masterfrom
sawenzel:detectorlist-active-modules

Conversation

@sawenzel

@sawenzel sawenzel commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

This PR makes the MC workflow take only detectors that the o2-sim detector list (--detectorList) builds.

Until now the active detectors came only from --readoutDets or the anchored run, so a detector missing from the list stayed active. With TRD leaving ALICE2.1, an ALICE2.1 workflow would still schedule the TRD digitisation and reconstruction, and pass TRD to --readoutDetectors, which o2-sim rejects for a module it does not build.

  • The detector list is read like o2-sim does, from $O2_ROOT/share/config/o2simdefaultdetectorlist.json or a name:path custom file; an unreadable list is an error, as in o2-sim.
  • isActive() is false for modules the list does not build, and they are dropped from --readoutDetectors with a message.
  • The ITS/IT3 choice in the task setup and the QED module list follow the list instead of its name.
  • An empty set of active detectors, also after removing ZDC, is now an error instead of enabling all.

Detector names are taken literally: an explicit ITS with ALICE2.1 is dropped as not built. IT3 still counts as ITS through isActive("ITS"), as before.

Checked with daily-20261116 and the list without TRD, at a fixed seed:

  • ALICE2 (pp, Pb-Pb with QED, and --readoutDets ITS,TPC,ZDC): workflow identical to master;
  • ALICE2.1: trddigi, trdreco and trdreco2 dropped;
  • --readoutDets ZDC without --with-ZDC, an unknown list name and a malformed list stop with an error;
  • a custom list drops the detectors it does not build, also from the QED task.

This should go in before the AliceO2 change that removes TRD from ALICE2.1 (AliceO2Group/AliceO2#16139).

https://its.cern.ch/jira/browse/O2-7267

This makes the MC workflow take only detectors that the o2-sim detector list builds.

- The detector list is read like o2-sim --detectorList does, from O2_ROOT or a name:path custom file; an unreadable list is an error, as in o2-sim.
- isActive() is false for modules the list does not build, and they are dropped from --readoutDetectors with a message, since o2-sim rejects them.
- The ITS/IT3 choice in the task setup and the QED module list follow the list instead of its name.
- An empty set of active detectors, also after removing ZDC, is now an error instead of enabling all.

https://its.cern.ch/jira/browse/O2-7267
@sawenzel
sawenzel force-pushed the detectorlist-active-modules branch from e7838d0 to 5a7e465 Compare November 16, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant