Skip to content

replace QC digit reader with O2 digit reader for MFT digit QC task in o2dpg_sim_workflow.py - #2551

Open
ehellbar wants to merge 1 commit into
AliceO2Group:masterfrom
ehellbar:pr2551
Open

ehellbar wants to merge 1 commit into
AliceO2Group:masterfrom
ehellbar:pr2551

Conversation

@ehellbar

@ehellbar ehellbar commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

This fixes https://its.cern.ch/jira/browse/O2-7331 observed in recent MC productions with empty TFs.

Two remarks:

  • using --suppress-triggers-output option suppresses sending the trigger output, but currently, the output is still defined unconditionally in the workflow spec. This will produce a harmless error message for each TF ([ERROR] Expected Lifetime::Timeframe data MFT/PHYSTRIG/0 was not created for timeslice 0 and might result in dropped timeframes) for a declared output which was not sent. This will be fixed with a follow up PR (declare trigger output in ITS/MFT digit reader only when running with triggers AliceO2#16145) for the digit reader in O2.
  • the previously used QC digit reader sends the data per ROF instead of per TF, leading to occupancy denominators in the MFT digit QC task larger by a factor of N_rofs_per_TF than they should be (since it expects a whole TF). This will be fixed automatically using the O2 digit reader which sends data per TF.

@github-actions

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/mft-digits-' + str(flp) + '.json',
objectsFile='mftDigitsQC.root')
needs=[getDigiTaskName("MFT")],
readerCommand='o2-itsmft-digit-reader-workflow --runmft --disable-mc --suppress-triggers-output --mft-digit-infile mftdigits.root' + staggMFT,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need suppress-triggers-output?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in https://github.com/AliceO2Group/AliceO2/blob/c84b32c0a8771584af70cb91a4dbb73265d68bc5/Detectors/ITSMFT/common/workflow/src/DigitReaderSpec.cxx#L294 we define a trigger output without this flag for which a dummy value is sent at the moment. But the QC task only subscribes to the DIGITS and DIGITSROF outputs, so the dummy trigger output is sent to the sink, i.e. it is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants