Repository navigation
feat: verified-facts audit, code compliance gate, and benchmark - #15
Conversation
Adds the remaining two quality layers from the gap analysis: 1. scripts/verify-spec.py — audits every style's API spec for internal contradictions (forbidden classes in component templates, required entries with no template backing, token colors outside the palette). Running it over the full catalog exposed real data-source defects (e.g. neo-brutalist required table vs template mismatch). 2. scripts/eval-check.py — mechanical compliance gate for generated code: forbidden classes, off-palette colors, and (with --component) missing required classes. Template-backed only, so spec-data inconsistencies never produce false failures on generated code. 3. scripts/benchmark.py — with/without-skill pass-rate suite. Current result: 0/4 without skill, 4/4 with skill (identical tasks, same eval-check scorer). SKILL.md gains: eval-check in the quality gate, spec-data-health guidance (trust template over required table; report inconsistencies), and the new scripts in Resources. CI gates all three new scripts and pins the benchmark.
|
Warning Review limit reached
Next review available in: 36 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cmd && { exit 1; } failed whenever eval-check correctly rejected violating
code (its nonzero exit propagated). Use if cmd; then fail; fi so the step
only fails when eval-check wrongly ACCEPTS violating code.
Adds the remaining two quality layers from the gap analysis:
verify-spec.py — audits every style's API spec for internal contradictions (forbidden classes in component templates, required entries with no template backing, token colors outside the palette). Full-catalog run exposed real data-source defects (e.g. neo-brutalist required table vs template mismatch: 124/146 styles have at least one issue).
eval-check.py — mechanical compliance gate for generated code: forbidden classes, off-palette colors, and (with --component) missing required classes. Template-backed only, so spec-data inconsistencies never produce false failures on generated code.
benchmark.py — with/without-skill pass-rate suite. Current: 0/4 without skill, 4/4 with skill (identical tasks, same eval-check scorer).
SKILL.md gains eval-check in the quality gate, spec-data-health guidance, and new scripts in Resources. CI gates all three and pins the benchmark.