[bfjelds (bfjelds)]

Change

• Wait for the Kubernetes Node before starting trident-acl-agent.
• Require two successful checks a second apart, with 60 checks and a 5-second request timeout.
• Fail the preflight when the Node remains unavailable; allow 400 seconds for startup.
• Leave existing restart policy and diagnostic checks unchanged.

Trident 0.28 exits successfully when kubeconfig exists but the Node has not registered. The path trigger then leaves the service and path units start-limited.

Build 188602915 failed six ACL scenarios with this sequence. In scenario-logs-1793393947, ACL/journalctl records the NodeGone exit at 21:05:18, registration at 21:05:18.190457, and start-limit failures at 21:05:22.

Validation

• Repository shell lint, embedded-command ShellCheck, POSIX shell syntax and systemd unit verification pass.
• Cloud E2E validation remains pending.

[github-actions]

Windows Unit Test Results

  3 files   18 suites   1m 19s ⏱️
666 tests 666 ✅ 0 💤 0 ❌
689 runs  689 ✅ 0 💤 0 ❌

Results for commit 59bd8ce.

♻️ This comment has been updated with latest results.

[bfjelds (bfjelds)]

Cameron Meissner (@cameronmeissner) / Adams Anaglo (@adamsanaglo) ... I believe this will address the trident-acl-agent missing-k8s-node issue breaking other e2e tests. I started https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=188664133&view=results and will monitor.

[Copilot]

🟡 Changes recommended

The Node lookup uses an unnormalized hostname, so mixed-case hostnames cause every probe to fail and prevent TAA from starting even when the Node is registered.

1 open issue

• Lowercase hostname before querying Kubernetes for the Node · New

What changed in this PR

Adds a Node-registration preflight to prevent trident-acl-agent from starting before its Kubernetes Node exists, addressing the reported startup race.

Changes:

• Requires two consecutive successful Node checks, one second apart.
• Limits preflight to 60 checks with a five-second request timeout and fails if registration remains unavailable.
• Sets the startup timeout to 400 seconds while preserving existing diagnostics and restart policy.

File	Description
parts/​linux/​cloud-init/​artifacts/​acl/​trident-acl-agent-override.conf	Adds the Node-registration gate and extends the service startup timeout.

_{Review effort: Balanced}

[github-actions]

Package	Line Rate	Health
test	0%	❌
windows	27%	❌
staging_cse_windows Package 1	68%	➖
debug	0%	❌
provisioningscripts	2%	❌
parts_windows Package 1	73%	➖
Summary	39% (1819 / 7006)	❌

[Copilot]

🔵 Needs a closer look

Cloud E2E validation remains pending on AMD64 and ARM64 to confirm startup and recovery avoid service/path start limits in the actual Trident 0.28 environment.

No open issues 🎉

1 resolved since last review

• Lowercase hostname before querying Kubernetes for the Node

_{Review effort: Balanced}

[github-actions]

Package	Line Rate	Health
shellspec spec	29%	❌
Summary	29% (4779 / 16475)	❌

[github-actions]

Package	Line Rate	Health
github.com/Azure/agentbaker/aks-node-controller	73%	➖
github.com/Azure/agentbaker/aks-node-controller/common	100%	✔
github.com/Azure/agentbaker/aks-node-controller/helpers	68%	➖
github.com/Azure/agentbaker/aks-node-controller/parser	88%	✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu	100%	✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils	89%	✔
github.com/Azure/agentbaker/aks-node-controller/utils	0%	❌
github.com/Azure/agentbaker/apiserver	24%	❌
github.com/Azure/agentbaker/cmd	0%	❌
github.com/Azure/agentbaker/cmd/starter	0%	❌
github.com/Azure/agentbaker/fuzz/api	0%	❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata	35%	❌
github.com/Azure/agentbaker/pkg/agent	78%	➖
github.com/Azure/agentbaker/pkg/agent/datamodel	77%	➖
github.com/Azure/agentbaker/pkg/agent/toggles	0%	❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel	87%	✔
Summary	75% (6059 / 8026)	➖