Repository navigation
Conversation
…e custom scheme Since around 10 November the Porsche identity server answers /authorize with 403 "unauthorized_client: Callback URL mismatch" for my-porsche-app://auth0/callback, before the e-mail is sent, so every new login fails. The current My Porsche app logs in with the same client_id and its HTTPS app link instead. A refused /authorize now reports its HTTP status instead of a bare failure.
Author
|
Duplicate from #100. Not needed anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logins fail since around 10 November (reported in CJNE/ha-porscheconnect#465 and CJNE/ha-porscheconnect#466): the Porsche identity server answers
/authorizewith 403unauthorized_client: Callback URL mismatchformy-porsche-app://auth0/callback, before the e-mail is sent. Installations keep working until their refresh token is rejected, then the full login fails and Reconfigure reports invalid authentication.Change
REDIRECT_URIis now the HTTPS app link the current My Porsche app uses with the sameclient_id:https://security.porsche.com/auth/en-GB/app/callback. The custom schemesmy-porsche-app://andmy-porsche-app-auth0://are both refused, and onlyen-GBis registered for the HTTPS link./authorizedoes not answer 302, the error message now carries the HTTP status (Could not fetch authorization code: HTTP 403) instead of hiding it.The resume flow already reads the
codefrom the redirectLocationwithout following it, so nothing else changes.Tests
/authorizewith the old URI givesCould not fetch authorization code: HTTP 403, and with the new one a 302 to the login screen.ruff checkpasses.EDIT: schaepi85 reached the same fix independently in CJNE/ha-porscheconnect#466. The User-Agent bump is not needed for the login and is left out. Once this is released, ha-porscheconnect needs the new version pinned in its manifest.