Skip to content

Update remote climatisation status check logic #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredriklj merged 1 commit into from
Nov 9, 2026
Merged

Update remote climatisation status check logic #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyporscheconnectapi/vehicle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from __future__ import annotations

import datetime

Check failure on line 5 in pyporscheconnectapi/vehicle.py

View workflow job for this annotation

GitHub Actions / ruff

ruff (ICN001) 

pyporscheconnectapi/vehicle.py:5:8: ICN001 `datetime` should be imported as `dt`
  help: Alias `datetime` to `dt`

Check failure on line 5 in pyporscheconnectapi/vehicle.py

View workflow job for this annotation

GitHub Actions / ruff

ruff (ICN001) 

pyporscheconnectapi/vehicle.py:5:8: ICN001 `datetime` should be imported as `dt`
  help: Alias `datetime` to `dt`
import json # only for formatting debug output
import logging
import re
Expand Down Expand Up @@ -101,7 +101,7 @@
last = self.last_global_update
if last is None:
return None
return datetime.datetime.now(datetime.timezone.utc) - last

Check failure on line 104 in pyporscheconnectapi/vehicle.py

View workflow job for this annotation

GitHub Actions / ruff

ruff (UP017) 

pyporscheconnectapi/vehicle.py:104:38: UP017 Use `datetime.UTC` alias
  help: Convert to `datetime.UTC` alias

Check failure on line 104 in pyporscheconnectapi/vehicle.py

View workflow job for this annotation

GitHub Actions / ruff

ruff (UP017) 

pyporscheconnectapi/vehicle.py:104:38: UP017 Use `datetime.UTC` alias
  help: Convert to `datetime.UTC` alias

@property
def has_remote_services(self) -> bool:
Expand Down Expand Up @@ -151,7 +151,7 @@
"""Return True if remote climatisation is on."""
status = self.data.get("HVAC_SUMMARY", {}).get("status")
_LOGGER.debug("Remote climatisation status is: %s", status)
return status is not None and status != "OFF"
return status in ("HEATING", "COOLING", "ON")

@property
def climatisation_target_temperature(self) -> float | None:
Expand Down
Loading