Repository navigation
Fix: Snapserver Discovery settings button behaviors - #243
Merged
CarlosDerSeher merged 1 commit intoSep 15, 2026
Conversation
…odifying snapserver discovery settings in the UI
Owner
|
@anabolyc since you did most of the work on the recent UI maybe you should review here? At first glance this seems right. |
Contributor
Seems to be fairly small and safe change. Good catch as well. |
Owner
|
@cbrenberg sorry I did have to revert the merge since this needs to go to develop branch. Please make a new PR into develop |
Owner
|
@cbrenberg ok did it myself now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small javascript change to ensure that the Restart and Save Changes buttons respond appropriately in response to modifying values within the Snapserver Discovery section of the General Settings page in the web UI.
Resolves #242