Repository navigation
Fix Improv WiFi issues with Power Management - #246
Merged
CarlosDerSeher merged 1 commit intoNov 3, 2026
Merged
Conversation
With CONFIG_PM_ENABLE and tickless idle, automatic light sleep stops the UART from receiving, so Improv requests over serial were never answered. Hold an ESP_PM_APB_FREQ_MAX lock from improv_init() until improv_deinit(). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
blattm
changed the title
Owner
|
Wouldn't this prevent light sleep at all times? I am uncertain about how the implementation works, it has been a while. But I believe improv is always active? Or is it disabled after successfull provisioning? |
Contributor
Author
|
I think |
Owner
|
I think you are right. Could you still verify this and then we definitely can merge. |
Contributor
Author
|
I just restarted a snapclient, looked at the logs and it deinitializes as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issues provisioning a new snapcast device, that were caused by PM interfering with improv's UART connection. I added a sleep lock around the improv code, to prevent this problem.