Repository navigation
fix(error-tracking): preserve URL path separators on Windows - #589
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
jakub-g
approved these changes
Oct 22, 2026
Member
|
@dajiaohuang could you please rebase this PR and sign your commit? We require signed commits for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
On Windows, the documented path-only
errorTracking.sourcemaps.minifiedPathPrefixis joined using the host filesystem separator. A real esbuild consumer with/static/jsandassets/main.jspassed\static\js\assets\main.jsto the sourcemap sender instead of/static/js/assets/main.js.This is independent of the debug-ID quoting change in #529; it does not change debug-ID extraction.
How?
Normalize native relative-path separators and use POSIX joining only for path-only URL prefixes. Filesystem paths and full-URL handling remain unchanged. Add a public-adapter build regression for all five supported bundlers and clarify the URL-path documentation.
Validation
yarn typecheck:allpassed twice; changed TypeScript files pass ESLint and Prettier;git diff --checkpassed.BUILD_PLUGINS_ENV=test, blocked network, dummy authentication and no real upload.Limits: the broader local runs were not green (factory 70/71, feature/helpers 138/163, Git 30/44); Windows/POSIX assertion assumptions, missing fixture dependency/Git setup, and the independently repaired URL behavior were distinguished rather than treating these counts as full acceptance. Root
yarn formatexceeded Windows command-line length; scoped ESLint passed.yarn cli integritystopped at childspawn yarn ENOENTalthough bundled Yarn itself ran directly, so full generated/compliance verification remains outstanding. No full browser, hosted-CI, live Datadog, or version-matrix validation is claimed.