Repository navigation
Conversation
… multipart payloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two client-side issues in
@dd/core/helpers/requestsurfaced during high-volume sourcemap uploads inweb-ui(companion concurrency PR: https://github.com/ddoghq/web-ui/pull/28126):Retry transient
fetch()network errors (ECONNRESET,EPIPE,ETIMEDOUT,UND_ERR_*):doRequest()wrapped bothgetData()andawait fetchImpl(...)in a singletry/catchthat calledbail(error).fetch()rejected withTypeError: fetch failed(wrappingECONNRESET,EPIPE,ETIMEDOUT, orUND_ERR_SOCKET),doRequest()calledbail(error)on attempt 1, skipping allNB_RETRIES(5) retries and failing the upload immediately withstatus_code:unknown.doRequest()now re-throws transientfetchnetwork errors soasync-retryretries them with backoff, while still bailing immediately ongetData()errors,AbortSignaltimeouts (AbortError/TimeoutError), and non-networkTypeErrors (such as locked/disturbed streams).Materialize compressed payloads in
createRequestData()before opening the HTTP request:createRequestData()returned a lazyreq.body.pipeThrough(new CompressionStream('gzip'))stream. When passed tofetch(), Undici immediately sent the HTTP request headers and the 10-byte gzip header (network.bytes_read: 10)—starting the intake edge's 30s/60s request-body receive timers—before the file-backed blobs were read from disk or compressed on Node's libuv threadpool. Under high concurrency, streams queued behind disk/zlib work sent 0 body bytes after the 10-byte gzip header for 60s and timed out withHTTP 408(response_flags: SI,stream_idle_timeout).createRequestData()now buffers the compressed payload in memory and setsContent-Lengthbefore returning, ensuring disk reads and gzip compression complete before the HTTP request headers are sent on the wire.Related Links
web-uiPR by @matissjanis-aboltins_ddog: https://github.com/ddoghq/web-ui/pull/28126