Repository navigation
T1337363 - DataGrid — E1046 is thrown when state is restored without columns and a row is focused - #36046
Open
bit-byte0 wants to merge 2 commits into
Open
T1337363 - DataGrid — E1046 is thrown when state is restored without columns and a row is focused#36046bit-byte0 wants to merge 2 commits into
bit-byte0 wants to merge 2 commits into
Conversation
| && this.changes.every((change) => change.changeType === 'updateFocusedRow'); | ||
|
|
||
| if (isUpdateFocusedRow) { | ||
| this.changes = [this.changes[this.changes.length - 1]]; |
Contributor
There was a problem hiding this comment.
nitpick
Suggested change
| this.changes = [this.changes[this.changes.length - 1]]; | |
| this.changes = [this.changes.at(-1)]; |
Contributor
Author
There was a problem hiding this comment.
at(-1) can return undefined, so TS won't let it go into this.changes. used slice(-1) instead - also short, and no ! needed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DataGrid no longer raises E1046 when
state()drops runtime grouping while a row is focusedHow
Focus data controller keeps only the last of several queued
updateFocusedRowchanges, soendUpdateno longer merges them into a full refresh over stale grouped items