Repository navigation
Conversation
An `RdpServer` held one `Credentials`, so a server with more than one account could not use NLA: CredSSP checked every client against that single identity. `RdpServer::set_credential_list` (and `ServerEvent::SetCredentialList` at runtime) takes a list. CredSSP checks the client's password against the entry with its user name, through `CredsspSequence::init_with_identities`; ClientInfo credentials must equal one of the entries. `Acceptor::set_credential_list` does the same for embedders driving the acceptor themselves. `set_credentials` keeps its behaviour as a list of at most one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FreeRDP-based clients open the advanced input channel and the Microsoft clients do not, so a server can tell them apart, for example to pick a codec only FreeRDP decodes reliably. RdpServerInputHandler::advanced_input_opened has an empty default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
org-event
temporarily deployed
to
llm-providers
November 3, 2026 07:26 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
breaking-change
Contributor
|
This pull request may overlap with #2356. The diff's credential-list work matches PR 2356's described scope almost exactly: Acceptor storing a Vec of Credentials with set_credential_list, CredsspSequence::init_with_identities matching by user name, RdpServer::set_credential_list and ServerEvent::SetCredentialList, and the same credssp_accepts_any_of_several_credentials test. The diff additionally carries an advanced-input-opened notification resembling PR 2358. This notice is advisory only. Automated review continues as usual, and how these pull requests relate is for maintainers and authors to decide. Note LLM-assisted content (no human feedback). |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.