Repository navigation
Conversation
|
🤖 Suggestions from an AI review. Feel free to ignore if not relevant.
|
|
Regarding the AI suggestion: it may be best to construct the glvis/lib/script_controller.cpp Line 456 in 4b9df8f using DataState new_state = win.data_state.CloneEmpty();instead of the default constructor. This, in particular, will copy the @najlkin, does this sound good to you? |
|
Yeah, that sounds good 👍 . I introduced the method just recently for exactly such cases, so the solution itself is not copied, but the settings are. Probably we will not need #378 then, but I need to check more closely 🤔 . |
Okay, done. |
| int ScriptController::ScriptReadDisplMesh(istream &scr, DataState &state, | ||
| bool parallel) | ||
| { | ||
| DataState meshstate; |
There was a problem hiding this comment.
This one should be also cloned to preserve all settings (current or future). I opened a new PR fixing all occurrences #384 😉 .
Similar to the
meshcommand, it captures reference nodes on the first load and visualizes displacement on subsequentpmeshloads.