feat(admin): add a Configuration page to view and edit central-manager settings by Devin-Holland · Pull Request #1988 · HarperFast/studio

Devin-Holland · 2026-10-20T15:14:34Z

Deploy order: HarperFast/central-manager#982 should merge and deploy first. Until it does, fabric_admin does not hold config:write, so this page stays hidden from them; the core super user sees it, without lock badges because current rows carry no superUserOnly flag.

⊙ Problem

Staff cannot see or change central-manager's Configuration table from Studio; it takes the core super user and a direct API call.

🤔 Is a JSON editor safe enough for staff?

Yes, because central-manager decides: HarperFast/central-manager#982 lets fabric_admin edit an allowlist of operational keys and refuses the rest. This page only hides the edits that would fail.

💡 Solution

New Admin → Configuration page: every key with its description and value, filterable.
Locked keys show a badge and no Edit button; the core super user sees the badge but keeps the Edit button.
Edit opens a JSON editor that refuses invalid JSON and numbers JSON would alter, and warns on a type change.
Save re-reads the key first and stops if someone changed it meanwhile. Failures use the standard error toast, and the editor stays open and locked while saving.

⚖️ Alternatives

Typed form per key — every new key would need a Studio change; the table's values are already JSON.
A server-side precondition on PATCH — closes the overwrite race fully, but Harper has no compare-and-set. The re-read before saving leaves only the gap between two requests.

🤔 Should read-only staff get the page too?

Not in this PR. Every staff role holds config:read, but the page exists to edit, so it is gated on config:write. Gating on config:read instead is a one-line change if read-only staff should see values.

🔧 Changes

src/features/admin/configuration/index.tsx — the page and edit dialog. JSON checks reject 1e400, integers past 2^53 and nesting too deep to send. Locks use central-manager's computed superUserOnly.
src/features/admin/configuration/queries/getConfiguration.ts, src/features/admin/configuration/mutations/useUpdateConfiguration.ts — load the list and save changes: re-read, PATCH, then refresh the list.
src/features/admin/routes.ts, src/features/admin/components/AdminShell.tsx — the route, and a nav item requiring config:write; AdminShell's existing check redirects a deep link from anyone without it.
src/integrations/api/api.patch.d.ts — the config:read and config:write permissions and the row type until the generated OpenAPI types include superUserOnly.

✅ Verification

pnpm test 5875 passing on this head. Page tests cover:
- the lock and Edit rules for fabric_admin and the super user;
- invalid JSON, the type warning, numbers JSON cannot round-trip, and deep nesting;
- the saved value, a refused save reported through the app's real error handler, and a stale save stopped before PATCH;
- the editor locked mid-save, then closing and refreshing, and a failure still reported after the page unmounts.
Reverting any of this round's fixes fails a test. Shell visibility and route tests include Configuration.
Rendered the real page against stub data in the browser (light and dark): lock badges, the editor, and its warnings look as described.
Not run against a deployed central-manager. The endpoint side was smoke-tested on released Harper 5.3.1 in HarperFast/central-manager#982.

_{🤖 Generated by Claude Code (Claude Opus 5.5); posted via @Devin-Holland.}

Related PRs: #1975 overlaps (AdminShell nav items, admin routes and the visibility test; whichever merges second keeps both pages), #1780 overlaps (both add types to api.patch.d.ts)
Complexity: medium

Deferred findings

e3cf9431bf9907fc nit maintainability — src/features/admin/configuration/index.tsx — local imports omit file extensions — NOT FILED
9662b6ba91556850 nit data-integrity — src/features/admin/configuration/mutations/useUpdateConfiguration.ts — whole-value PATCH from stale snapshot loses concurrent edits — NOT FILED
c061a4cfe6c1e8e6 nit performance — src/features/admin/configuration/index.tsx — per-keystroke stringify/lowercase/closed-dialog parse over all rows — NOT FILED
64d604298c694ca2 nit maintainability — src/features/admin/configuration/queries/getConfiguration.ts — double cast instead of patched endpoint types — NOT FILED
7244681086f2b812 nit maintainability — src/features/admin/configuration/index.tsx — exports with no consumer outside their own file — NOT FILED

_{Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; blocked=cursor-composer(auth); declined=cursor-grok,cursor-kimi,cursor-muse,muse; rounds=3; full=1 @ 3832ab9}

_{Review-Attention: read ~5m (decisions: global-error-reporting, client-side-precondition, gate-page-on-config-write, raw-value-display, client-side-superuser-gate, strict-integer-rejection, do-less-alternative) @ 3832ab9}

…r settings A staff-only /admin/configuration page listing every Configuration key with its description and current value. Accounts holding config:write (fabric_admin, and the core super user) can edit a value as JSON: the editor rejects JSON that doesn't parse, warns when an edit changes the value's type, and shows a refused save inline. Keys central-manager marks superUserOnly (security controls such as the SSO session cap and host SSH keys) show a lock and can only be edited by the core super user. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…SON can't round-trip The editor no longer closes while a save is in flight, so a dismissed dialog can't drop the result; the list refresh and success toast now live on the mutation itself. Values containing a non-finite number (1e400) or an integer past 2^53 are refused instead of being saved as null or rounded, and a refused-save message clears once the value is edited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

… overwrite a newer value A save now re-reads the key and stops if it changed since the editor opened, since PATCH replaces the whole value. Failures go through the global toast, so a refused or unanswered save is still reported after navigating away. The editor locks while saving, deep nesting no longer throws during render, and a row with no value edits as null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…lue as null Drops the stack-dependent depth case to 1,000 (100,000 still catches both regressions), shows a row with no value as null in the table as the editor does, and trims comments that restated the code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

gemini-code-assist

Code Review

This pull request introduces a new Configuration section to the admin panel, allowing authorized staff and super users to view and edit central-manager settings with JSON validation and concurrency checks. It adds the /admin/configuration route, updates navigation visibility, and introduces new config:read and config:write permissions. The review feedback suggests improving the layout of the edit dialog by wrapping the title and description in a DialogHeader component, and adjusting the size and spacing of the LockIcon inside the "Super user" badge for better visual alignment.

gemini-code-assist · 2026-10-20T15:17:36Z

@@ -0,0 +1,211 @@
+import { Badge } from '@/components/ui/badge';
+import { Button } from '@/components/ui/button';
+import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogTitle } from '@/components/ui/dialog';


Import DialogHeader from @/components/ui/dialog to wrap the dialog title and description, ensuring proper layout and padding according to shadcn/ui standards.

Suggested change

import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogTitle } from '@/components/ui/dialog';

import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, DialogTitle } from '@/components/ui/dialog';

gemini-code-assist · 2026-10-20T15:17:37Z

+			<DialogContent className="max-w-2xl">
+				<DialogTitle className="font-mono">{entry?.name}</DialogTitle>
+				<DialogDescription>{entry?.description || 'No description.'}</DialogDescription>


Wrap DialogTitle and DialogDescription inside a DialogHeader component to maintain correct layout, alignment, and spacing as defined by shadcn/ui guidelines.

Suggested change

<DialogContent className="max-w-2xl">

<DialogTitle className="font-mono">{entry?.name}</DialogTitle>

<DialogDescription>{entry?.description || 'No description.'}</DialogDescription>

<DialogContent className="max-w-2xl">

<DialogHeader>

<DialogTitle className="font-mono">{entry?.name}</DialogTitle>

<DialogDescription>{entry?.description || 'No description.'}</DialogDescription>

</DialogHeader>

gemini-code-assist · 2026-10-20T15:17:37Z

+																	<Badge variant="secondary" className="text-[10px]">
+																		<LockIcon />Super user
+																	</Badge>


The LockIcon inside the Badge is disproportionately large for a text-[10px] badge. Add size classes to the icon and a gap to the badge for proper visual alignment.

Suggested change

<Badge variant="secondary" className="text-[10px]">

<LockIcon />Super user

</Badge>

<Badge variant="secondary" className="gap-1 text-[10px]">

<LockIcon className="h-3 w-3" />Super user

</Badge>

github-actions · 2026-10-20T15:20:06Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	80.05%	14992 / 18728
🔵	Statements	79.99%	15915 / 19895
🔵	Functions	75.49%	4012 / 5314
🔵	Branches	74.75%	11661 / 15600

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/features/admin/routes.ts	72.72%	100%	60%	72.72%	33-34, 40-41, 47-48
src/features/admin/components/AdminShell.tsx	29.41%	46.66%	60%	33.33%	43-65
src/features/admin/configuration/index.tsx	91.8%	85.33%	88.88%	94.23%	74, 77, 122-123, 144
src/features/admin/configuration/mutations/useUpdateConfiguration.ts	100%	66.66%	100%	100%
src/features/admin/configuration/queries/getConfiguration.ts	100%	100%	100%	100%

Generated in workflow #2401 for commit 3832ab9 by the Vitest Coverage Report Action

Devin-Holland and others added 4 commits October 20, 2026 10:41

gemini-code-assist Bot reviewed Oct 20, 2026

View reviewed changes

dawsontoth approved these changes Oct 23, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(admin): add a Configuration page to view and edit central-manager settings - #1988

feat(admin): add a Configuration page to view and edit central-manager settings#1988
Devin-Holland wants to merge 4 commits into
stagefrom
admin-configuration-page

Devin-Holland commented Oct 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 20, 2026

Uh oh!

gemini-code-assist Bot Oct 20, 2026

Uh oh!

gemini-code-assist Bot Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogTitle } from '@/components/ui/dialog';
	import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, DialogTitle } from '@/components/ui/dialog';

Conversation

Devin-Holland commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⊙ Problem

🤔 Is a JSON editor safe enough for staff?

💡 Solution

⚖️ Alternatives

🤔 Should read-only staff get the page too?

🔧 Changes

✅ Verification

Deferred findings

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 20, 2026

Coverage Report

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Devin-Holland commented Oct 20, 2026 •

edited

Loading