Repository navigation
Conversation
OkHttpOcppWampClient.onFailure reset the state to DISCONNECTED before testing it against CONNECTING, so a failure while connecting always took the connection-lost branch. The connect() listener then received a spurious onConnectionLost, and the auto-reconnect client reported every failed attempt as a connection lost followed by a connection failure. Capture the previous state first, as onClosing already does, and forward onConnectionFailure to the connect() listener before releasing connect(), whose cleanup drops that listener. connect() still throws the IOException. Closes IZIVIA#148
|
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OkHttpOcppWampClient.onFailurereset the state toDISCONNECTEDbefore testing it againstCONNECTING, so a failure while connecting was reported asonConnectionLostinstead ofonConnectionFailure. The previous state is now captured first, asonClosingalready does, andonConnectionFailureis forwarded to theconnect()listener beforeconnect()is released (it still throws theIOException). Behaviour change: with auto-reconnect (thenewClientdefault), a failed attempt no longer emits a spuriousonConnectionLostbeforeonConnectionFailure. Two new tests against a port with no listener (direct and auto-reconnect client) fail ondevand pass with the fix; full build green (1212 tests).Closes #148