Repository navigation
Conversation
Insprill
requested changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lyrics break when Genius puts inline markup inside a line or a sidebar block between paragraphs, as described in #55.
The parser now reads each line as a whole before deciding whether it's a heading, joins text split over inline tags, and treats the start of every lyrics container as a paragraph break. The template no longer adds whitespace between the parts of a line. This also fixes an empty heading above the first section of every song, and a page error when the lyrics contain a link that isn't an annotation.
The parser had no tests, so I added some. One runs against a small placeholder page laid out like a Genius lyrics page (containers split by sidebar and ad blocks, inline markup, multi-line and heading annotations). Three small hand-written ones cover what those pages don't: Genius has since fixed the "M ike" lyrics, links that are or aren't annotations, and the template output, since half of the "M ike" fix is there.
Closes #55