Skip to content

Fix usync-ping last attempt result and readme ping example - #22

Merged
KevinJump merged 2 commits into
v17/mainfrom
fix/ping-last-attempt
Nov 6, 2026
Merged

Fix usync-ping last attempt result and readme ping example#22
KevinJump merged 2 commits into
v17/mainfrom
fix/ping-last-attempt

Conversation

@KevinJump

@KevinJump KevinJump commented Nov 6, 2026

Copy link
Copy Markdown
Member
  • usync-ping now reports success (exit 0) when the server responds on the final retry. It tracks whether a connection was made rather than comparing the attempt count to the retry limit.
  • The readme's command line ping example now uses -k for the client secret and -i for the client id, matching the options in SyncCommandBase.

Fixes #20
Fixes #21

🤖 Generated with Claude Code

KevinJump and others added 2 commits November 6, 2026 16:49
@KevinJump @claude
Report success when usync-ping connects on its last attempt
0c7c52a 
Track whether a connection was made instead of comparing the attempt
count to the retry limit, which treated a success on the final attempt
as a failure.

Fixes #20

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KevinJump @claude
Fix the command line options in the readme ping example
42b1df3 
Fixes #21

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
Closed
Closed
@KevinJump
KevinJump merged commit d9a8e3c into v17/main Nov 6, 2026
4 checks passed
@KevinJump
KevinJump deleted the fix/ping-last-attempt branch November 6, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Readme example uses the wrong command line options usync-ping reports failure when it connects on the last attempt

1 participant

@KevinJump