Repository navigation
Update URIs - #2684
Merged
Merged
Update URIs#2684
Conversation
lexaknyazev
force-pushed
the
uri-upd
branch
2 times, most recently
from
October 23, 2026 16:20
7d9585e to
1587b13
Compare
lexaknyazev
marked this pull request as ready for review
October 23, 2026 16:52
javagl
approved these changes
Oct 23, 2026
javagl
left a comment
javagl
left a comment
Contributor
There was a problem hiding this comment.
Reviewed in call, looks fine.
lexaknyazev
force-pushed
the
uri-upd
branch
3 times, most recently
from
October 23, 2026 21:00
754952b to
993f974
Compare
aaronfranke
reviewed
Oct 24, 2026
aaronfranke
approved these changes
Oct 24, 2026
aaronfranke
approved these changes
Oct 25, 2026
javagl
approved these changes
Oct 25, 2026
Contributor
There was a problem hiding this comment.
I think that the new Implementation Note makes sense as a "heads up". It also makes sense to not even try to list "all the problematic cases" (for Windows or other specific OSes). Pointing out the "case-(in)sensitivity" is worthwhile being included there, because it's important regardless of the OS (and even an issue within URLs that are used in networks, given the obscure mix of parts that are and that aren't case sensitive).
LGTM, Aaron to confirm
EDIT: Ah, 3 minutes late... 😕
emackey
approved these changes
Oct 25, 2026
weegeekps
reviewed
Oct 27, 2026
weegeekps
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2245.