Repository navigation
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Replacing explicit API authentication with UI storage state requires inspection of the unavailable ApiHelpers 17.7.1 authentication contract or a clean E2E run to verify user-group lookup and editor provisioning.
No open issues 🎉
1 file not reviewed
src/uSupport/Client/package-lock.json: Generated file
What changed in this PR
This PR updates a frontend dependency and changes E2E editor provisioning to reuse the saved admin session.
Changes:
- Update the top-level DOMPurify lockfile resolution from 3.4.16 to 3.4.17.
- Make editor setup depend on admin setup and use its saved browser state instead of explicitly refreshing API credentials.
| File | Description |
|---|---|
src/uSupport/Client/package-lock.json |
Updates the top-level DOMPurify resolution and integrity hash. |
src/uSupport.E2E/tests/editor/editor.setup.ts |
Loads saved admin state for editor provisioning. |
src/uSupport.E2E/playwright.config.ts |
Requires admin setup to complete before editor setup. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.