Skip to content

fix(config): clarify Linux audio sink selection - #6061

Open
XiaoTong6666 wants to merge 1 commit into
LizardByte:masterfrom
XiaoTong6666:fix/linux-audio-sink-guidance
Open

XiaoTong6666 wants to merge 1 commit into
LizardByte:masterfrom
XiaoTong6666:fix/linux-audio-sink-guidance

Conversation

@XiaoTong6666

@XiaoTong6666 XiaoTong6666 commented Nov 7, 2026 •

Copy link
Copy Markdown

Description

The Linux/FreeBSD audio sink help suggests pactl info | grep Source, which can return a microphone name. Using it as audio_sink causes audio capture to fail.

The existing pacmd list-sinks | grep "name:" command is kept. The incorrect Source lookup is replaced with pactl get-default-sink in the Web UI and documentation.

Screenshot

No layout changes.

Issues Fixed or Closed

Roadmap Issues

None.

Testing

  • npm ci --ignore-scripts --no-audit --no-fund: passed.
  • npm run build: passed.
  • npm test (Vitest with coverage): passed.
  • git diff --check: passed.
  • Verified pactl get-default-sink on PipeWire 1.6.9.
  • No new tests needed for static help text. Existing Web UI tests cover localization and markup.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

AI assistance was used for investigation, wording, source review, and testing. The contributor should review the diff and its scope before merging.

This pull request was prepared by ChatGPT, GPT-6 (thinking level: unspecified by the interface).

@XiaoTong6666
XiaoTong6666 force-pushed the fix/linux-audio-sink-guidance branch 3 times, most recently from 7accf42 to 0f19982 Compare November 7, 2026 19:14
@XiaoTong6666
XiaoTong6666 marked this pull request as ready for review November 7, 2026 19:15
@XiaoTong6666
XiaoTong6666 force-pushed the fix/linux-audio-sink-guidance branch from 0f19982 to 9269dc4 Compare November 8, 2026 13:43
@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant