Repository navigation
Bug fixxing - #5
Open
SURYANSH-RAI wants to merge 2 commits into
Open
SURYANSH-RAI wants to merge 2 commits into
SURYANSH-RAI wants to merge 2 commits into
Conversation
The branch held only part of the R04 change: the ports, rerank and persist stages expected rank/computation_version, but pipeline.ts, match.repo.ts and the Gemini provider were still the old versions. This broke the web typecheck (5 errors) and 5 tests (rank NOT NULL violation, pipeline returning RerankResult instead of a list). Completes R04 as designed: - Migration 0004 adds event_matches.rank and computation_version - save() stores the final reranked position; reads order by rank - Rerank records whether the order came from the model or the score - Unit test for the pipeline and a real-Postgres acceptance test
The "attendee queries" suite read the attendee that the login challenge suite deletes in its afterAll, so it depended on run order, and the first suite closed the shared pool before the second ran. - The attendee queries suite now creates and removes its own attendee - The pool is closed once at file level, after both suites finish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes: complete R04 match ranking, fix login test isolation
This branch is based on R01 (
109a751) and fixes the two problems found in a full check of the platform (typecheck, lint, tests, build, migrations, and a run of the app).1.
bug fixx-incomplete-r04-match-rankThe R04 change (save the final match order) was only partly in place. The ports and the rerank and persist steps expected
rankandcomputation_version, butpipeline.ts,match.repo.tsand the Gemini provider were still the old versions.Effect before the fix: 5 web typecheck errors and 5 failing tests. Saving matches failed (
rankcannot be null), and the pipeline returned aRerankResultinstead of the list of matches.What this commit completes:
0004_match_rank.sqladdsevent_matches.rankandcomputation_version. Existing rows get a rank in the order they are shown today.save()stores each match's final position after reranking, and reads sort byrank, so the order stays the same after a page reload.v1+llm:gemini:<model>) or by score (v1+score).tests/unit/matching-pipeline.test.tsandtests/integration/match-rank.test.ts, which runs against real Postgres.2.
bug fixx-login-challenge-test-isolationIn
tests/integration/login-challenge.test.ts, the "attendee queries" tests used the attendee that the login-challenge tests delete when they finish, so the result depended on run order. The login-challenge tests also closed the shared database connection before the second group ran.Verification
npm run typecheck: passes (4/4 packages)npm run lint: passesnpm test: 78/78 passing (unit and integration)npm run build: passesnpm run db:migrate: database up to date with migration 0004/api/health/readyreports database and Keycloak ready; protected pages redirect to/login?returnTo=…;/api/mereturns 401 without a sessionNot covered: a logged-in session and match generation with a real Gemini key have not been tested by hand.
Deploy note
Run
npm run db:migratebefore deploying. Migration 0004 is required for saving matches.Merge notes
feature/r02-email-google-config) and R03 (fix/login-redirect-loop-for-expired-sessions).mainhas one conflict, inReadMe.md. It comes from R01 (main still has the old Supabase README) and is not caused by this branch.fix/r04-persist-match-rankis superseded by this branch and can be closed or deleted.