Repository navigation
Feature/candidate eligibility - #6
Open
SURYANSH-RAI wants to merge 1 commit into
Open
SURYANSH-RAI wants to merge 1 commit into
SURYANSH-RAI wants to merge 1 commit into
Conversation
Hidden, incomplete, removed, and other-event participants no longer appear in fresh retrieval, cached search results, or saved matches. - One SQL rule (visible, named, profile saved) shared by listCandidates, cached-id hydration, and saved-match reads; saved matches are filtered on read, so a participant who becomes eligible again reappears - The pipeline filter also requires a completed profile - Viewers must have saved their event profile to search or compute matches; hidden viewers can still browse - Intro requests require a visible recipient with a completed profile - Unit tests for the rules and a real-Postgres test for all three paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce candidate eligibility on every results path
Hidden, incomplete, removed, and other-event participants no longer appear through any results path: fresh search/match retrieval, cached search results, or saved matches.
Builds on R04 (
bug-fixxing), which this needs because saved matches are read byrank.Rules agreed for this item
profile_updated_atis set). This is the same rule the app already uses to send people to the profile page.Changes
listCandidates)findCandidatesByIds)listForParticipant)ELIGIBLE_CANDIDATEininfrastructure/postgres/participant.repo.tsand used by all three queries.CompleteProfileSpecificationindomain/matching/specifications/, used by the intent filter stage.