Repository navigation
Conversation
…ation of limitations changing in time.
clio-met
approved these changes
Jan 2, 2026
Collaborator
There was a problem hiding this comment.
@efvik Nice! Could you please add a function (maybe in aux.py) that can create the limits pandas DataFrame from a set of variables, limits and exclusive/inclusive? It may be difficult for the user to make a dataframe that fits exactly what you expect in _weather_window_simulator.
The two new plot functions have not been added to the test file.
Also, please do not forget to add the two plotting functions to the documentation.
Member
|
@efvik is this ready to merge? |
Collaborator
Author
|
Yes, but no. Missing tests and docs. |
Member
|
@efvik Can you add the missing tests and docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation of limitations changing in time.