Repository navigation
fix(release): build each arch natively and verify package architecture (#77) - #80
Merged
Merged
Conversation
… arch (#77) The x64 mac build reused arm64 node_modules, so sharp/libvips, canvas and Prisma engines were arm64-only and the app crashed on Intel Macs. Split the release matrix per arch (macos-15-intel / macos-latest / windows / ubuntu x64 / ubuntu arm), merge latest-mac.yml, unpack @img libs from asar, and add a package architecture self-check script used in release and CI. Windows arm64 installer is dropped (no Prisma win-arm64 engine). Fixes #77
AI Code Review SummaryPR: #80 (fix(release): build each arch natively and verify package architecture (#77)) Overall AssessmentNo blocking issue was detected in the reviewed diff; keep focused regression testing before merge. Major Findings by SeverityNo major issues identified from the reviewed diff. Actionable Suggestions
Potential Risks
Test Suggestions
File-Level Coverage Notes
Inline Downgraded Items (processed but not inline)
Coverage Status
Uncovered list:
No-patch covered list:
Runtime/Budget
Reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
Root cause: release built
--mac --x64 --arm64from a singlenpm cion arm64macos-latest, so the x64 app shipped arm64 sharp/libvips, canvas and Prisma engines. Linux x64 also crashed on launch, becauselibvips-cpp.so.8.17.3stayed inside the asar.Changes
release.yml: each architecture builds on its own runner (macos-15-intel,macos-latest,windows-latest,ubuntu-latest,ubuntu-24.04-arm).npm ci --ignore-scripts, and builds run with--publish never.latest-mac.ymlfiles are merged; the job fails if an architecture is missing.asarUnpacknow includesnode_modules/@img/**.build:*scripts build only the host architecture.scripts/verify-package-arch.mjs,scripts/package-load-check.cjsand theverify:packagescript check that packaged binaries match the target architecture, that required modules are present, and that they load when the host can run them.Tests:
test:unit973 passed, typecheck and build pass.verify:packageand launches under xvfb (it crashed before the fix).Not verified: a real launch on an Intel Mac or an arm64 Mac, Windows packaging, and actual runs of
release.ymlandci.yml. A release candidate run is needed to confirm these.Merge order: #72 → #75 → #77 (none of the three PRs touch the same files), then run a release candidate to validate the release pipeline.