Repository navigation
fix: preserve assumptions in threat-model JSON - #367
Open
rksharma-owg wants to merge 1 commit into
Open
rksharma-owg wants to merge 1 commit into
rksharma-owg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON export reduced assumptions to their names. Reloading a model with element assumptions failed validation, while model-wide assumptions lost descriptions and excluded threat IDs. Resolved excluded findings also exported the assumption's exclusion set as a string.
This registers
Assumptionwith the existing structured serializer and uses it for embedded assumptions. Four regression cases cover model-wide and element assumptions, including whether a threat remains excluded after exporting, importing and resolving a model. The README documents the corrected export shape.Compatibility: exported assumptions now contain
name,descriptionandexclude, rather than a name string. The existing importer accepts these objects, and legacy model-wide string inputs remain supported. Consumers that expect exported assumptions to be strings will need to accept objects.Validation for
a941c70b917a0075297887a3b851fa8869894a8b, against381dea05c58055ba218e632510dd3a327d2bf215:Newly discovered during local investigation; no existing issue or competing fix found.