Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
(use of Copilot to) Enable compilation with full LLVM toolchain, with the changes here needed for compilation with LLVM Flang. Compilation with the LLVM suite should hopefully make future conda packaging easier, give a more consistent cross-platform approach, and improve the Fortan-C/C++ interfaces. Care was taken to not impact the compilation with Classic Flang or ROCm Flang as used in some of the HPC systems with Kynema.
In addition to touching a few cmake-files, there were numerous string-copy calls that pass through other compilers fine but not flang. Also, at least one instance of a
cot(x)function needing to be flipped to1/tan(x). Finally, LLVM Flang does not also ship with openmp, so one or two of theuse OMP_LIBcalls was moved inside an#ifdefI expect some scrutiny and iteration during code review.
Related issue, if one exists
Impacted areas of the software
The r-test suite was run locally on my Mac with errors just in the numerical precision
Additional supporting information
Generative AI usage
Assisted by: GitHub Copilot support@github.com
Test results, if applicable
Might need guidance from the OF team here on how best to accommodate an LLVM Flang option in the test suite.