Skip to content

pxc-galera-operations: strict-mode PK DDL, Clone SST 8.0 status, SST encryption - #31

Open
ImTheKai wants to merge 2 commits into
Percona-Lab:mainfrom
ImTheKai:fix/pxc-galera-operations-correctness
Open

ImTheKai wants to merge 2 commits into
Percona-Lab:mainfrom
ImTheKai:fix/pxc-galera-operations-correctness

Conversation

@ImTheKai

Copy link
Copy Markdown
Collaborator

Correctness fixes for pxc-galera-operations (SKILL.md and references/operations.md) from a fact-check against docs.percona.com. Each change was checked against the page cited.

Changes

  • Strict mode now also blocks PK-less DDL. As of PXC 8.4.11-11 (2026-10-05) and 9.7.2-2, pxc_strict_mode=ENFORCING/MASTER also sets sql_require_primary_key=ON globally. CREATE/ALTER of a table without a PK then fails, and setting sql_require_primary_key=OFF in those modes is an error. Updated the PK wrong/right row, the pxc_strict_mode section, the PK gotcha, and the pxc_strict_mode row in the Key variables table.
  • Clone SST on 8.0 is tech preview. operations.md said "Clone is also available on the 8.0 line from 8.0.41+". It now says the feature is tech preview on 8.0 and should be tested before production use. The docs page says "currently in tech preview" and recommends testing before production; it does not say "not for production" in so many words. Also updated the wsrep_sst_method row.
  • SST encryption. The guidance said only "rely on pxc-encrypt-cluster-traffic". It now gives the supported method: [sst] encrypt=4 with ssl-ca/ssl-cert/ssl-key. This defaults to 4 when pxc-encrypt-cluster-traffic=ON and falls back to 0 if that setting is OFF; transferfmt=nc cannot use it. Clone SST uses the MySQL ssl-* settings (or clone_ssl_* on the joiner), with the certs kept outside the datadir. Updated the wrong/right row, the gotcha, and the Encryption and Clone SST sections in operations.md.
  • (optional) Added the repl.force_sst_after_inconsistency Galera option (8.4.11-11+, off by default) to the Key variables table. Added the 8.4 → 9.7 upgrade target: 9.7.2 or newer, because 8.4.11 → 9.7.1 is unsupported.
  • Added Sources links for the XtraBackup SST options page and the 8.4.11-11 release notes. The frontmatter description, existing URLs and the search_percona_docs(...) snippet are unchanged.

🤖 Generated with Claude Code

@EvgeniyPatlan EvgeniyPatlan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, most of this is good, but one change needs fixing before merge.

sql_require_primary_key under ENFORCING/MASTER on 8.4. PXC-5106 shipped in 8.4.11-11, but it was reverted on the 8.4 branch afterwards: percona/percona-xtradb-cluster#2379 (PXC-5341, "Revert pxc_strict_mode=ENFORCING (or MASTER) to 8.4.10 behavior [8.4]", merged 2026-10-09). The new behavior stays only in 9.7+. As written ("from 8.4.11-11 / 9.7.2-2", "8.4.11-11+") the skill will be wrong for the next 8.4 release. Affected places:

  • pxc-galera-operations/SKILL.md lines 27, 71, 103
  • pxc-galera-operations/references/operations.md line 58

I'd describe it as 9.7.2-2+ behavior, and mention that 8.4.11-11 had it but later 8.4 releases revert to 8.4.10 behavior.

Also worth adding: lowering pxc_strict_mode afterwards doesn't reset sql_require_primary_key, it stays ON until changed explicitly.

Minor: the force-SST row's version wording could be more precise.

ImTheKai and others added 2 commits November 11, 2026 19:33
…encryption

- ENFORCING/MASTER sets sql_require_primary_key=ON from 8.4.11-11 / 9.7.2-2,
  so PK-less CREATE/ALTER fails
- Clone SST on 8.0 is tech preview
- document [sst] encrypt=4 + ssl-* and Clone SST's use of MySQL ssl-* settings
- add repl.force_sst_after_inconsistency and the 8.4 -> 9.7.2+ upgrade target

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed on 8.4)

Address review on Percona-Lab#31: PXC-5106 shipped in 8.4.11-11 but was reverted on
the 8.4 branch (PXC-5341), so describe the sql_require_primary_key behavior
as 9.7.2-2+. Note that lowering pxc_strict_mode does not reset
sql_require_primary_key, and tighten the force_sst_after_inconsistency
version wording.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ImTheKai

Copy link
Copy Markdown
Collaborator Author

Thanks @EvgeniyPatlan, addressed in a26a918 (and rebased on main):

  • sql_require_primary_key: now described as 9.7.2-2+ behavior in SKILL.md (lines 27, 71, 103) and references/operations.md. Each mention notes that 8.4.11-11 had it but later 8.4 releases revert to 8.4.10 behavior (PXC-5341 / PXC-5341: Revert pxc_strict_mode=ENFORCING (or MASTER) to 8.4.10 behavior [8.4] percona/percona-xtradb-cluster#2379). Added the 9.7 strict-mode page and the revert PR to Sources.
  • Lowering the mode: added that dropping to PERMISSIVE/DISABLED doesn't reset sql_require_primary_key; it stays ON until set explicitly, and existing sessions keep their session value (per the 9.7 strict-mode page).
  • force-SST row: now says it was added in 8.4.11-11 and 9.7.2-2, is off by default and runtime-settable, and covers the voted-out-for-inconsistency case. The IST write-set case is attributed to the 8.4 notes only, because the 9.7.2-2 notes mention only the first case.

🤖 Generated with Claude Code

@ImTheKai
ImTheKai force-pushed the fix/pxc-galera-operations-correctness branch from bc150af to a26a918 Compare November 11, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants