Repository navigation
Conversation
EvgeniyPatlan
left a comment
There was a problem hiding this comment.
Thanks, most of this is good, but one change needs fixing before merge.
sql_require_primary_key under ENFORCING/MASTER on 8.4. PXC-5106 shipped in 8.4.11-11, but it was reverted on the 8.4 branch afterwards: percona/percona-xtradb-cluster#2379 (PXC-5341, "Revert pxc_strict_mode=ENFORCING (or MASTER) to 8.4.10 behavior [8.4]", merged 2026-10-09). The new behavior stays only in 9.7+. As written ("from 8.4.11-11 / 9.7.2-2", "8.4.11-11+") the skill will be wrong for the next 8.4 release. Affected places:
pxc-galera-operations/SKILL.mdlines 27, 71, 103pxc-galera-operations/references/operations.mdline 58
I'd describe it as 9.7.2-2+ behavior, and mention that 8.4.11-11 had it but later 8.4 releases revert to 8.4.10 behavior.
Also worth adding: lowering pxc_strict_mode afterwards doesn't reset sql_require_primary_key, it stays ON until changed explicitly.
Minor: the force-SST row's version wording could be more precise.
…encryption - ENFORCING/MASTER sets sql_require_primary_key=ON from 8.4.11-11 / 9.7.2-2, so PK-less CREATE/ALTER fails - Clone SST on 8.0 is tech preview - document [sst] encrypt=4 + ssl-* and Clone SST's use of MySQL ssl-* settings - add repl.force_sst_after_inconsistency and the 8.4 -> 9.7.2+ upgrade target Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed on 8.4) Address review on Percona-Lab#31: PXC-5106 shipped in 8.4.11-11 but was reverted on the 8.4 branch (PXC-5341), so describe the sql_require_primary_key behavior as 9.7.2-2+. Note that lowering pxc_strict_mode does not reset sql_require_primary_key, and tighten the force_sst_after_inconsistency version wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks @EvgeniyPatlan, addressed in a26a918 (and rebased on main):
🤖 Generated with Claude Code |
bc150af to
a26a918
Compare
Correctness fixes for
pxc-galera-operations(SKILL.md and references/operations.md) from a fact-check against docs.percona.com. Each change was checked against the page cited.Changes
pxc_strict_mode=ENFORCING/MASTERalso setssql_require_primary_key=ONglobally.CREATE/ALTERof a table without a PK then fails, and settingsql_require_primary_key=OFFin those modes is an error. Updated the PK wrong/right row, thepxc_strict_modesection, the PK gotcha, and thepxc_strict_moderow in the Key variables table.wsrep_sst_methodrow.pxc-encrypt-cluster-traffic". It now gives the supported method:[sst] encrypt=4withssl-ca/ssl-cert/ssl-key. This defaults to 4 whenpxc-encrypt-cluster-traffic=ONand falls back to 0 if that setting is OFF;transferfmt=nccannot use it. Clone SST uses the MySQLssl-*settings (orclone_ssl_*on the joiner), with the certs kept outside the datadir. Updated the wrong/right row, the gotcha, and the Encryption and Clone SST sections in operations.md.repl.force_sst_after_inconsistencyGalera option (8.4.11-11+, off by default) to the Key variables table. Added the 8.4 → 9.7 upgrade target: 9.7.2 or newer, because 8.4.11 → 9.7.1 is unsupported.search_percona_docs(...)snippet are unchanged.🤖 Generated with Claude Code