You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds an activity for Tentacle BBS, a site that hosts classic BBS door games (LORD, Trade Wars 2002, Barren Realms Elite and a few hundred more) and plays them in the browser.
While a game session is open, the activity shows the door's title, a second line with its platform, genre and version when the site has them (for example "DOS · RPG · 4.08 Beta (2006)"), the door's card as the large image and the session time. The other pages show the game being viewed on a door's page, or a browsing status.
The site names the door in a <meta name="tentacle-presence"> tag on the play page and on the door's page. It leaves the tag out for doors marked as adult content, and for hidden or staff-only doors, so the activity shows only "Playing on Tentacle BBS" for those and never receives their names.
Settings: privacy mode (no door is named), door as activity name (the small image then shows the site's logo), and buttons.
Proof showing the creation/modification is working as expected
Playing a door (left: my Discord profile, right: the site):
The same with "Show Game as Activity Name" on, and the activity settings open:
Activity settings in the extension:
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.
Summary by CodeRabbit
New Features
Added Discord activity support for Tentacle BBS, showing relevant details while playing or browsing.
Added privacy controls, with privacy mode enabled by default behavior remaining off; game-name display and activity buttons are also off by default and available only when privacy mode is off.
Activity details adapt to the available game and page information, and live sessions can show a Play Game button.
No actionable comments were generated in the recent review.
Walkthrough
Adds Tentacle BBS service metadata and settings. The presence script reads door metadata and session state to set Discord activity for live sessions, door pages, and general browsing.
Changes: Tentacle BBS presence
Layer / File(s)
Summary
Service metadata and presence settings websites/T/Tentacle BBS/metadata.json, websites/T/Tentacle BBS/presence.ts
Adds service metadata and privacy, game-name, and button settings. The presence script parses door metadata and reads the settings.
Live session activity websites/T/Tentacle BBS/presence.ts
On /play, clears activity for non-live sessions. For live sessions, uses session time and available door metadata to select generic, chat-style, or door-specific activity.
Door-page and browsing activity websites/T/Tentacle BBS/presence.ts
Loads portal strings and clears activity if loading fails. Sets door-page or browsing activity based on the page and available metadata.
This adds Discord presence for Tentacle BBS live sessions, door pages and browsing, with privacy, game-name and button settings. No concrete defects were found, and privacy mode and settings-read failures fall back to non-identifying activity. It looks ready to merge.
Security architecture risk: Minimal · up to dbad9
The activity gates game details on the privacy setting and falls back to private output when settings cannot be read. The inspected change establishes no material security or failure-containment defect. Exclusion of restricted games remains the website’s responsibility.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The authority exercised by the new code is publication or clearing of the current user’s Discord activity. Its observed inputs are local settings and Tentacle BBS page content; the inspected flow does not perform administrative, credential, or persistent-data operations.
Trust Boundaries and Controls
observed — The activity enforces the user’s privacy gate locally but delegates mature, hidden, and staff-only door exclusion to the publisher’s omission of the meta tag. That publisher-side guarantee is documented, not independently enforced by this consumer.
observed — The consumer does not fully validate metadata field types or restrict URL schemes and destinations. URL resolution permits absolute inputs to flow into activity images and links. Attacker write access to the tag and downstream acceptance of dangerous values were not established, so this is a trust assumption rather than a verified attack path.
Resilience and Maintainability Implications
observed — Portal updates capture privacy, route, and metadata before awaiting localized strings, then publish without a local generation check. Whether overlapping invocations can publish stale state depends on runtime ordering guarantees that were unavailable for inspection.
Hardening Proposals
proposed — Consider validating metadata field types and permitted URL schemes, with generic output or clearing on conversion failure. This would make the publisher-consumer contract more defensive; it is not remediation for a demonstrated exploit.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "feat(Tentacle BBS): add activity" matches the main change. The PR adds a Tentacle BBS Discord activity (metadata.json and presence.ts) that shows browsing and door-game status. The title is…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "feat(Tentacle BBS): add activity" matches the main change. The PR adds a Tentacle BBS Discord activity (metadata.json and presence.ts) that shows browsing and door-game status. The title is short and names the site and the new feature. It does not describe the privacy settings or door metadata handling, but it does not need to cover every detail.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 74eefaa0-6ce4-4e16-8f79-d54db37817ce
Commits
Reviewing files that changed from the base of the PR and between a0ce989 and dbad9a0.
Files selected for processing: 2
websites/T/Tentacle BBS/metadata.json
websites/T/Tentacle BBS/presence.ts
Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an activity for Tentacle BBS, a site that hosts classic BBS door games (LORD, Trade Wars 2002, Barren Realms Elite and a few hundred more) and plays them in the browser.
While a game session is open, the activity shows the door's title, a second line with its platform, genre and version when the site has them (for example "DOS · RPG · 4.08 Beta (2006)"), the door's card as the large image and the session time. The other pages show the game being viewed on a door's page, or a browsing status.
The site names the door in a
<meta name="tentacle-presence">tag on the play page and on the door's page. It leaves the tag out for doors marked as adult content, and for hidden or staff-only doors, so the activity shows only "Playing on Tentacle BBS" for those and never receives their names.Settings: privacy mode (no door is named), door as activity name (the small image then shows the site's logo), and buttons.
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected
Playing a door (left: my Discord profile, right: the site):
The same with "Show Game as Activity Name" on, and the activity settings open:
Activity settings in the extension:
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit