Skip to content

fix: exclude empty ranges from proptest_range_boundaries #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kerollmops merged 1 commit into from
Oct 26, 2026
Merged

fix: exclude empty ranges from proptest_range_boundaries #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion roaring/tests/range_checks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ proptest! {
fn proptest_range_boundaries(
// Ensure we can always subtract one from start
start in 1..=262_143_u32,
len in 0..=262_143_u32,
// An empty range is always contained, so len must be non-zero for the negative cases to hold
len in 1..=262_143_u32,
) {
let mut bitmap = RoaringBitmap::new();
let end = start + len;
Expand Down
4 changes: 3 additions & 1 deletion roaring/tests/treemap_range_checks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ proptest! {

#[test]
fn proptest_range_boundaries(
// Ensure we can always subtract one from start
start in 1..=262_143_u64,
len in 0..=262_143_u64,
// An empty range is always contained, so len must be non-zero for the negative cases to hold
len in 1..=262_143_u64,
) {
let mut rb = RoaringTreemap::new();
let end = start + len;
Expand Down
Loading