Repository navigation
Report statistics byte counts in bytes - #397
Open
emschwartz wants to merge 1 commit into
Open
emschwartz wants to merge 1 commit into
emschwartz wants to merge 1 commit into
Conversation
n_bytes_array_containers multiplied the capacity of the Vec<u16> by size_of::<u32>(), and n_bytes_bitset_containers added the bitmap's capacity in bits (65,536) instead of its size in bytes (8,192). BitmapStore::capacity was only used for this, so remove it. With run and bitset bytes now matching CRoaring, the fuzzer compares them again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #371 (thanks @fjmaco for the clear write-up; happy to close this if you already have a branch).
n_bytes_array_containersnow counts 2 bytes per slot of theVec<u16>, andn_bytes_bitset_containerscounts 8,192 bytes per bitmap instead of its bit count. Array containers still count capacity, not length.BitmapStore::capacityhad no other caller, so it is removed. Anyone reading these fields will see array counts halve and bitset counts drop 8x.Run and bitset byte counts now match CRoaring's, so the
against_croaringfuzzer compares them again (array bytes stay excluded, since they depend on capacity). A 90-second local fuzz run passed. The newstatistics_bitset_bytestest fails without the fix (left: 65536, right: 8192), and thestatistics()doctest goes from 512 to 256.Authored with Claude (claude-opus-5-5).