Repository navigation
fix(frontend): say "workflows" in the billing and usage-limit copy merged after the rename - #15590
Conversation
…rged after the rename #15251 (SECRT-2853) renamed user-facing "agent" copy to "workflow"; the usage-limits and payment-due work merged a day later brought "agents" back in 18 strings on the paywall, the billing page's plan offer, and the out-of-budget and payment-due messages. Each says "workflows" now, reworded by meaning, and the tests that assert them follow. TourHero and the plans.ts pricing bullets stay, as the rule says; they await a product decision. Fixes SECRT-2968. Co-authored-by: Claude Opus 5.5 (Claude Code) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughBilling, payment-recovery, and plan messages now refer to saved workflows instead of saved agents. Related test expectations use the updated wording. ChangesSaved-work copy
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
🔍 PR Overlap DetectionThis check compares your PR against all other open PRs targeting the same branch to detect potential merge conflicts early. 🔴 Merge Conflicts DetectedThe following PRs have been tested and will have merge conflicts if merged after this PR. Consider coordinating with the authors.
Summary: 1 conflict(s), 0 medium risk, 0 low risk (out of 1 PRs with file overlap) Auto-generated on push. Ignores: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #15590 +/- ##
==========================================
- Coverage 86.87% 86.86% -0.01%
==========================================
Files 4947 4947
Lines 378328 378324 -4
Branches 33657 33657
==========================================
- Hits 328656 328640 -16
- Misses 44196 44206 +10
- Partials 5476 5478 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/review |
|
🤖 Review of |
There was a problem hiding this comment.
✅ Verdict: Approved — No findings require changes before approval; this review counts as an approval.
Clean copy-only rename of 18 billing/paywall/usage-limit strings from 'agents' to 'workflows' with matching test updates. No identifiers, routes, or matchers affected; deferred exceptions correctly left untouched; no security, performance, or architectural impact.
Risk level: low | Human review: not required | Duration: 199s | Reviewed: 34827b3c
GitHub CI on reviewed head: success
Validation and specialist details
Specialist Reports
| Specialist | Status | Summary |
|---|---|---|
| security | ✅ PASS | Pure user-facing copy change (agents→workflows) in billing/paywall/usage strings with tests updated; no security impact, no matchers or auth paths affected. |
| architect | ✅ PASS | Clean copy-only rename of 18 user-facing 'agent'→'workflow' strings in billing/paywall/usage-experience, with tests updated in lockstep, matchers intact, and all rule exceptions respected. |
| performance | ✅ PASS | Copy-only rename of 'agent(s)' to 'workflow(s)' in billing/usage strings and tests, with zero performance impact. |
| testing | ✅ PASS | Copy-only rename of billing/usage 'agents' strings to 'workflows'; test updates are consistent, assertions are exact, and no stale old-copy assertions remain anywhere in source or tests. |
| quality | ✅ PASS | Clean copy-only rename of user-facing "agents" to "workflows" across billing/usage-limit surfaces, with matching test updates and all identifiers and awaiting-decision exceptions correctly preserved. |
| product | ✅ PASS | Clean copy-only rename of 18 billing/usage/paywall strings from "agents" to "workflows" with matching test updates, fully compliant with the AGENTS.md copy rule and its deferred exceptions. |
| discussion | ✅ PASS | No failing required checks on the current head (4 of 35 still pending) and no open human-reviewer threads to report. |
| ui-reviewer (local) | ✅ PASS | Clean copy-only rename of 18 billing/usage-limit strings from 'agents' to 'workflows' with matching test updates, no broken matchers, and documented exceptions (plans.ts, TourHero, AutoPilot) correctly left untouched. |
| ui-reviewer (hosted) | ✅ PASS | Clean copy-only follow-up that reworks 18 billing/usage-limit 'agent' strings to 'workflow' per the AGENTS.md rule, with matching test updates and exceptions correctly preserved; no defects found. |
Dev brings #15403 (send at reset, the out-of-budget panel for Max and a running-low hint), #15589 (a deleted skill stays deleted), #15545 (mobile chat input polish), #15590 (billing copy), #15594 (HubSpot in the MCP catalog) and the revert #15572 (PostHog flags read from each deployment's own project again). No conflicts. #15589 rewrites skill deletion and storage in tools/skills.py; the index builders the first message uses (skills_context_block and its helpers) are untouched. Co-authored-by: Claude Opus 5.5 (Claude Code) <noreply@anthropic.com>
The mainline's dev merge (b3e3576): #15403, #15589, #15545, #15590, #15594 and the revert #15572. skills_test.py conflicts on its imports: dev adds behavior_fingerprint beside the baseline engine's _prepend_skills_notice_to_current_message, which this branch deleted with the engine. The fingerprint import stays; nothing else in the file used the baseline helper. Co-authored-by: Claude Opus 5.5 (Claude Code) <noreply@anthropic.com>
Fixes SECRT-2968. Follow-up to #15251 (SECRT-2853).
Why / What / How
Why: #15251 renamed user-facing "agent" and "graph" copy to "workflow", and #15502 wrote the rule into root
AGENTS.md. The usage-limits and payment-due work that merged a day later (#15215 and its stack) brought "agents" back in 18 strings people see: the paywall, the billing page's plan offer, and the out-of-budget and payment-due messages.What: each of those strings says "workflows" instead, and the tests that assert them follow.
How:
devsince fix(platform): say "workflow" instead of "agent" or "graph" in user-facing copy (SECRT-2853) #15251's merge commit (ce4f592926): string literals, plus JSX text on its own line, for agent/graph in any form. The backend added none.TourHero("Build AI agents by just chatting") and theplans.tspricing bullets, which await a product decision. The plan bullet changed here copies that wording on the paywall and billing page; the rule says new text beside those exceptions follows it, so the copies say "Workflows" whileplans.tsstays as it is.Changes 🏗️
services/usageExperience/presentation.ts(6),services/usageExperience/payment.ts,PaywallGate/PaywallModal.tsx,settings/billing/.../SubscriptionTab.tsx: "Your chats, workflows and results are saved."PaywallGate/components/PaywallHeader.tsx: "Your chats, workflows and files are saved."settings/billing/.../BillingOffer.tsx,organisms/UsageExperience/PlanOffer.tsx: "Your chats, workflows and files stay where they are", "Workflows that keep working in the background on a schedule"PaywallGate/components/PaywallPlanChoices.tsx: "Your conversations and workflows stay saved. Cancel anytime." and the background bulletBillingOffer.tsx,AutopilotUsageCard.tsx: "…your conversations and workflows."presentation.test.ts,payment-recovery.test.tsx,PaywallModal.payment.test.tsx,RateLimitResetDialog.test.tsxAgents and large language models used
Checklist 📋
For code changes:
ce4f592926)TZ=UTCas in CItsc --noEmitcleanFor configuration changes:
.env.defaultis updated or already compatible with my changesdocker-compose.ymlis updated or already compatible with my changes🤖 Generated with Claude Code