Skip to content

Darkmode fixes - #1048

Merged
minimaluminium merged 2 commits into
TryGhost:mainfrom
jessehouwing:main
Oct 19, 2026
Merged

minimaluminium merged 2 commits into
TryGhost:mainfrom
jessehouwing:main

Conversation

@jessehouwing

@jessehouwing jessehouwing commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

Improves Dark and Auto (prefers dark) styling for highlighted text, keyboard keys, and bold figure captions.

  • Use translucent white borders and inset shadows for kbd elements.
  • Retain the pale-yellow highlight hue at 20% opacity with near-white text.
  • Make bold text in figure captions readable against the dark background.
  • Preserve existing input and textarea text colors: native fields retain white backgrounds, so changing their text to white makes entered values invisible.

Merged the latest main and regenerated built assets to resolve conflicts.

Validation:

  • pnpm install --frozen-lockfile
  • pnpm build
  • pnpm test:ci (includes theme build and zip)
  • pnpm exec gscan .
  • Checked the rebuilt CSS on an actual Ghost 6.72 test post in Chrome in Dark, Auto-dark, Light, and Auto-light modes. Form values remain readable; caption, highlight, and keyboard styles match the intended dark-mode changes.

@coderabbitai

coderabbitai Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 622bc127-ff52-44d1-b386-eae4d6be64ad
📥 Commits

Reviewing files that changed from the base of the PR and between 4a1a1cb and 15fdc30.

⛔ Files ignored due to path filters: 2
  • assets/built/global.css.map is excluded by !**/*.map
  • assets/built/screen.css.map is excluded by !**/*.map
📒 Files selected for processing: 3
  • assets/built/global.css
  • assets/built/screen.css
  • assets/css/screen.css
+-------------------------------------------------------------------+
| This refactor is like rearranging furniture during an earthquake. |
+-------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Walkthrough

This PR updates dark-mode styling in the CSS stylesheet. Changes include adding new styling for kbd elements with border-color and box-shadow properties, introducing new dark-mode rules for mark elements with semi-transparent yellow background and light text color, and adding color rules for strong text within figcaption elements in dark mode. Additionally, the text color for form controls (input and textarea) in dark mode is changed from a color-mod-based value to rgba(255, 255, 255, 0.9). The minified built stylesheet is regenerated to reflect these updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks: Passed 3
Check name Status Explanation
Title check Passed The title 'Darkmode fixes' is related to the changeset but lacks specificity; it refers to the general category of changes without highlighting the main improvements (kbd, mark, figcaption, and input …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check Passed The pull request description directly matches the changeset. It describes dark-mode and auto-color updates for kbd elements, highlighted text, figure captions, form controls, and regenerated CSS asset…
Full details: Title check

Explanation

The title 'Darkmode fixes' is related to the changeset but lacks specificity; it refers to the general category of changes without highlighting the main improvements (kbd, mark, figcaption, and input styling).

Full details: Description check

Explanation

The pull request description directly matches the changeset. It describes dark-mode and auto-color updates for kbd elements, highlighted text, figure captions, form controls, and regenerated CSS assets.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@JohnONolan

Copy link
Copy Markdown
Member

Would you be able to rebase to resolve conflicts and, if possible, share screenshots of before/after the changes?

@minimaluminium

Copy link
Copy Markdown
Member

Thanks for the improvements! Kept the caption, highlight, and keyboard styling changes, but reverted the input/textarea colors after testing showed white text on white field backgrounds.

@minimaluminium
minimaluminium merged commit a22690d into TryGhost:main Oct 19, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants