Repository navigation
Nullable problems fail the build (v13) - #186
Merged
Merged
Conversation
…ble; no null-forgiving operators in production or test code; source scan test; submodule pointers Public API annotation changes (binary compatible): the LicenseService parameter of ConfigurationService, SessionService, StripeSessionService, StripeSettingsService, StripeSettingsApiController and ConfigurationApiController is LicenseService?; ICurrencyService.GetCurrencyForContentAsync and the add-to-basket view component take IPublishedContent? (they already handled null). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eutral comment in LoggingTests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…r flags a logical not after a lambda arrow (as v17); test cases Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…in); submodule pointers to the dev/v13 merge commits (Stripe, Stripe.Forms, uSync, Stripe.uSync) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes nullable problems fail the build in every project (tests included):
Directory.Build.propssetsNullableto enable andWarningsAsErrorsto includenullable. Null-forgiving operators (null!,default!and every other!) are gone from production and test code; nulls are handled, guarded or annotated. A source-scan test fails if any production file brings one back.Not merged: please review.
🤖 Generated with Claude Code
Note: this branch is based on v13/ci-testcontainers (PR #182, still open), because the parent repo's dev/v13 pins that commit (it adds the UmbCheckout.Testing project the solution references). Merge #182 first, or this PR carries its commit too.
The null-forgiving scan now also catches x!( x![ x! == y x! : y and null ! (as on v17); nothing new was found.