Repository navigation
Filter cmdline/search history by typed text on <Up>/<Down> (#3951) - #10125
Open
MahbodHastam wants to merge 1 commit into
Open
MahbodHastam wants to merge 1 commit into
MahbodHastam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In Vim,
<Up>/<Down>on the command line recall only the history entries that start with what you've typed so far (:help c_<Up>), while<C-p>/<C-n>browsw history unfiltered (:help c_CTRL-P).Changes:
<Up>/<Down>skip history entries that don't start with the text before the cursor. This applies to both:command history and//?search history.<C-p>/<C-n>are unchanged (unfiltered), matching Vim.historyIndexwas initialized tohistory.lengthinstead ofundefined, so the typed text was never saved. The existing test had a TODO for this , which is now resolved.<Up>again, the edited text becomes the new prefix.Example (from #3951): search
/abc, then/def, then type/aand press<Up>. Before:/def. After:/abcWhich issue(s) this PR fixes
Fixes #3951
Special notes for your reviewer:
<Up>and<C-p>actions are split into separate classes insrc/actions/commands/commandLine.tsso each can passmatchPrefix.test/cmd_line/command.test.ts; the existing<C-p>/<C-n>test now asserts:w|instead of:|.