You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Pin verifier-server to main after the review fixes - #68
Bumps the vzgcoders/verifier-server composer pin from 838750d to 05ddbc1ae91cc28215fd682f045353c3f51ff6a7, the Verifier-server main head after the review PRs Valgorithms/Verifier-server#4 to #8 were merged. composer.lock is updated to match.
What the bot gets from the new pin:
A request that throws no longer closes the whole verifier (500 instead of a fatal exit).
/verified/ with a trailing slash routes like /verified, so the remote cURL path in Verifier::verify() works.
Records are validated on write (17 to 20 digit Discord id, normalised ckey, duplicates refused with 403), matching HostedVerificationSource::validate so the desktop instances never reject the whole list.
Atomic JSON writes, corrupt verify.json is reported instead of silently loading as empty, DB storage mode works past the first insert.
OAuth2 web endpoints (/dwa, /ss14wa) now use a verifier_session cookie and async provider calls; getSessions()[endpoint][key]['user'] is still read the same way.
No bot code changes. The in-process contract (handleEndpoint, arrayToRequestString, getState()->getVerifyList(), getEndpoint('/ss14verified')) is unchanged and covered by tests/verifier-integration.php.
Test plan
composer validate --no-check-publish: OK (pre-existing warnings only)
php tests/verifier-integration.php: pass on the new pin
Verifier-server #4 to #8 merged: requests that fail no longer close the
listener, trailing-slash paths route, verify.json is written atomically
and refused when corrupt, records are validated and ckeys normalised
before storage, .env loads on every platform, and OAuth2 sessions are
keyed by cookie with asynchronous provider calls. The bot's call pattern
is unchanged; tests/verifier-integration.php passes on the new pin.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WTP2S4qKEFT8a6a6yFEL4
The verifier-server pin is updated; no merge-blocking issue was established.
Architecture risk: Low · up to 5420d
The change affects 1 system.
Changed systems:composer.json
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — composer.json (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in composer.json: The vzgcoders/verifier-server dependency’s dev-main commit pin changes from 838750d11353a8223c652f678bfdfee32b40edb3 to 05ddbc1ae91cc28215fd682f045353c3f51ff6a7.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title identifies the verifier-server pin update and its purpose. The dependency remains on dev-main, with a new pinned commit.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 92692fa0-cd6e-4e06-b1bc-74f5a7255330
Commits
Reviewing files that changed from the base of the PR and between adb257e and 5420d89.
Files ignored due to path filters: 1
composer.lock is excluded by !**/*.lock
Files selected for processing: 1
composer.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
2026-11-06: head 5420d89 bumps the verifier-server pin to 05ddbc1 (Verifier-server #4 to #8 merged). Local: composer validate --no-check-publish OK, php tests/verifier-integration.php pass, php tests/http-dependency.php and php tests/windows/hosted-verifier.php pass, php -l clean. CI: all 60 jobs green across the five workflows on this head, verifier-integration run https://github.com/Valgorithms/Civilizationbot/actions/runs/42214691699, CodeRabbit no actionable comments. Not verified: the live bot on Val's PC, which picks the new pin up on its next update and restart. Merged per Val's instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Summary
Bumps the
vzgcoders/verifier-servercomposer pin from838750dto05ddbc1ae91cc28215fd682f045353c3f51ff6a7, the Verifier-servermainhead after the review PRs Valgorithms/Verifier-server#4 to #8 were merged.composer.lockis updated to match.What the bot gets from the new pin:
/verified/with a trailing slash routes like/verified, so the remote cURL path inVerifier::verify()works.HostedVerificationSource::validateso the desktop instances never reject the whole list.verify.jsonis reported instead of silently loading as empty, DB storage mode works past the first insert./dwa,/ss14wa) now use averifier_sessioncookie and async provider calls;getSessions()[endpoint][key]['user']is still read the same way.No bot code changes. The in-process contract (
handleEndpoint,arrayToRequestString,getState()->getVerifyList(),getEndpoint('/ss14verified')) is unchanged and covered bytests/verifier-integration.php.Test plan
composer validate --no-check-publish: OK (pre-existing warnings only)php tests/verifier-integration.php: pass on the new pinphp tests/http-dependency.php,php tests/windows/hosted-verifier.php: passphp -loversrc/: no syntax errorsverifier-integration.ymlon this headChangelog:
Generated by Claude Code
Summary by CodeRabbit