Skip to content

test(state): make the early stop window test independent of clock resolution #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wizzomafizzo merged 1 commit into from
Oct 28, 2026
Merged

test(state): make the early stop window test independent of clock resolution #1706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/service/state/early_stop_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,15 @@ func TestEarlyStop_OtherGameIsPublished(t *testing.T) {
func TestEarlyStop_StopAfterTheWindowIsNotEarly(t *testing.T) {
t.Parallel()
st, _, stopped := newLaunchStopState(t)
st.mu.Lock()
st.earlyStopWindow = time.Nanosecond
st.mu.Unlock()

launchPublished(t, st, "game.nes")
// Move the launch and its publication out of the window rather than
// shrinking the window: a coarse clock, as on Windows, can read the same
// instant for the publication and the stop, which is inside any window.
st.mu.Lock()
st.lastLaunchAt = st.lastLaunchAt.Add(-2 * st.earlyStopWindow)
st.activeMediaPublishedAt = st.activeMediaPublishedAt.Add(-2 * st.earlyStopWindow)
st.mu.Unlock()
st.RecordMediaStop(models.MediaStopReasonStopped)
st.SetActiveMedia(nil)

Expand Down
Loading