Repository navigation
Preserve YOLO box dimensions in MMDetection conversion - #3178
dajiaohuang wants to merge 3 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe YOLO-to-Pascal pixel conversion now uses exact half-widths and half-heights to calculate box edges. Odd-sized boxes can produce fractional edge coordinates. ChangesYOLO box conversion
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to Odd-sized boxes retain their intended dimensions, and the supported MMDetection pipeline preserves fractional box coordinates. No merge-blocking issue remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each box with care Comment |
|
This changes behavior in a maintenance-only integration (MM/Labelbox/COCO) rather than fixing a defect, and it has no owner review or integration run behind it. Holding it: it needs the integration owner to decide whether the new behavior is wanted. No action needed from you now. |
Fixes #3177.
Use the actual half-width and half-height when converting YOLO center/size boxes into LTRB coordinates. This preserves odd and subpixel dimensions. Alias the imported helper so the integration wrapper calls the helper instead of recursively calling itself.
Validation at
e3bc9838005a821ee56a416449f382fdb95d5226:git diff --checkpassed. The published dispatcher reproducedRecursionError; focused checks of the actual checkout's import binding and conversion functions pass pixel, fractional and empty-array cases. The helper and its two existing NumPy regressions are unchanged from their previously passing revision. The complete module and MMDetection runtime were not exercised:mmcvandmmdetare unavailable. Native integration acceptance remains unverified.