Skip to content

Preserve async cancellation on task completion #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Preserve async cancellation on task completion #3234

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31fabed
Preserve async cancellation on task completion
dajiaohuang Oct 2, 2026
b5ffbd0
test(async): cover cancellation during producer completion
dajiaohuang Oct 2, 2026
4ccb3a2
Cover public promise cancellation before late results
dajiaohuang Oct 3, 2026
a481771
Remove standalone cancellation tests pending canonical harness integr…
dajiaohuang Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cpp/async/handle_base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,9 @@ class handle_base
inline void set_value(T&& value)
{
std::unique_lock lock(data_->lock_);
if (is_cancelled(data_)) {
return;
}
ASSERT(!has_result(data_));
data_->result_ = Result(std::forward<T>(value));
on_result_updated(std::move(lock), data_);
Expand All @@ -247,6 +250,9 @@ class handle_base
inline void set_value(T&& value)
{
std::unique_lock lock(data_->lock_);
if (is_cancelled(data_)) {
return;
}
ASSERT(!has_result(data_));
data_->result_ = Result(std::forward<T>(value));
on_result_updated(std::move(lock), data_);
Expand All @@ -257,6 +263,9 @@ class handle_base
requires(std::is_void_v<Result>)
{
std::unique_lock lock(data_->lock_);
if (is_cancelled(data_)) {
return;
}
ASSERT(!has_result(data_));
data_->result_->set_fulfilled();
on_result_updated(std::move(lock), data_);
Expand All @@ -265,6 +274,9 @@ class handle_base
inline void set_exception(std::exception_ptr ex)
{
std::unique_lock lock(data_->lock_);
if (is_cancelled(data_)) {
return;
}
ASSERT(!has_result(data_) || !data_->result_->succeeded());
data_->result_ = std::move(ex);
on_result_updated(std::move(lock), data_);
Expand Down