Skip to content

fix: let generated agents inherit caller identity - #13

Closed
Himanshu040604 wants to merge 1 commit into
mainfrom
codex/fix-agent-runtime-integration
Closed

Himanshu040604 wants to merge 1 commit into
mainfrom
codex/fix-agent-runtime-integration

Conversation

@Himanshu040604

@Himanshu040604 Himanshu040604 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Goal

Let agents created from the template inherit the caller's identity during OS Manager delegation. The template currently assigns a fixed anonymous user, which causes delegation from development MCP callers without a user identity to be refused.

Change

Remove the fixed user_id from the create-agent skill template and document the caller identity behavior. This PR changes only the skill file.

Verification

  • Built a fresh disposable AgentOS stack from current main plus this commit.
  • Twice, an anonymous MCP request caused OS Manager to delegate to an agent rendered from the updated template. The persisted child run invoked the calculator and its session had no user owner.
  • Twice, a control agent with the old fixed user was refused by the ownership guard without a child session.
  • git diff --check passed. The disposable stack, database volume, image and private test-key file were removed after testing.

AWS AgentCore is not part of this caller identity path. No AWS deployment result is claimed for this change.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Himanshu040604
Himanshu040604 force-pushed the codex/fix-agent-runtime-integration branch from 25bdff1 to acd6a6e Compare November 9, 2026 09:42
@Himanshu040604 Himanshu040604 changed the title fix: restore engineer execution and MCP integration fix: let generated agents inherit caller identity Nov 9, 2026
@ashpreetbedi ashpreetbedi mentioned this pull request Nov 16, 2026
@ashpreetbedi

Copy link
Copy Markdown
Contributor

Consolidated into #20, which retains the relevant work and updates the template to Agno 3.2.0. Retains caller identity inheritance in the shared create-agent skill. The replacement is pushed; local gates and CI pass. Closing this superseded PR for a single review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants